Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of .gitignore in subdirectories #28

Open
3 tasks
blaugold opened this issue May 24, 2022 · 0 comments
Open
3 tasks

Handling of .gitignore in subdirectories #28

blaugold opened this issue May 24, 2022 · 0 comments

Comments

@blaugold
Copy link
Collaborator

blaugold commented May 24, 2022

Nx only seems to take the .gitignore at the workspace root into account. add-nx-dart-to-monorepo does this too, since it's based on add-nx-to-monorepo.

  • add-nx-dart-to-monorepo should refuse to proceeded when .gitignores in subdirectories exist.
  • The documentation should make it explicit that monorepos are expected to have only one .gitignore at the workspace root.
  • add-package generator should handle removing .gitignores in packages.

Update: It would be a lot less complicated to just have .gitignore files work as expected. .gitignores in Flutter packages can be quite elaborate and are generated by the flutter tool when the packages is created or when platforms are added. They also contain ignore rules that are relative to the .gitignore. Automatically merging those into a single .gitignore reliably, is a non-trivial task.

Update: PR to add support for nested ignore files to Nx nrwl/nx#10455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant