Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react devtools need to be able to connect to the eval-frame #1720

Open
bcolloran opened this issue Apr 8, 2019 · 1 comment
Open

react devtools need to be able to connect to the eval-frame #1720

bcolloran opened this issue Apr 8, 2019 · 1 comment

Comments

@bcolloran
Copy link
Contributor

related to #1719 -- we need to be able to connect to the eval-frame with react devtools to monitor perf. we might try this: https://github.com/eddyerburgh/react-dev-tools-iframe-webpack-plugin
or even adapt the code directly: https://github.com/eddyerburgh/react-dev-tools-iframe-webpack-plugin/blob/master/index.js

it looks like this code might overwrite the variable that allows react devtools to connect to the main window, so it might be the case that if you connect to the eval frame you cannot connect to the main window. in that case, we would want to put this behind a command line flag

@bcolloran
Copy link
Contributor Author

(note: this is much less important now that we have so few react components in the eval-frame)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant