Add printing support for reports that are longer than one page #2582
Conversation
There was a problem hiding this comment.
Thanks for looking at this @mehmetoguzderin! I did some followup research myself and it does sound like this is the best possible approach given how the printing APIs work, we can see what @bcolloran thinks (note that I expect things will slow down a bit during the end-of-year holidays).
| @@ -16,9 +16,17 @@ export class ViewModeToggleButtonUnconnected extends React.Component { | |||
| }; | |||
There was a problem hiding this comment.
We probably would want to factor this into its own higher-level component, as it's not really a button anymore.
There are other minor UI Chrome elements that we want in the report view (like a spinner icon when the document is loading) so this might be an opportunity to pave the way for that.
| variant="text" | ||
| mini | ||
| > | ||
There was a problem hiding this comment.
Could probably use a printer icon as opposed to a textual button here, I'm sure material ui has one.
| style.position = "static"; | ||
| style.border = "none"; | ||
| style.overflow = "visible"; | ||
| } |
There was a problem hiding this comment.
I suspect it is possible to do this with pure css / emotion, which is probably preferable.
|
thanks for the PR @mehmetoguzderin -- unfortunately, i think this is not the way we want to go with this issue |
|
@bcolloran Thanks for the feedback! |
Aims to fix #2563 issue.
This pull request adds a printing button that calls printing from iframe to the left of
EXPLOREwhen using report view and changes the styling of the fixed container when in report view to make it possible to print a clean page without undesired bordering and page limiting.