Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor api specs #18

Open
ans-ioki opened this issue Nov 2, 2021 · 1 comment
Open

Refactor api specs #18

ans-ioki opened this issue Nov 2, 2021 · 1 comment

Comments

@ans-ioki
Copy link
Collaborator

ans-ioki commented Nov 2, 2021

I keep coming back to how platform_api_spec.rb and passenger_api_spec.rb look and how they slowed me down during the Endpoint refactoring. It's just too much repetition for my taste. Too many tests for the same path, the same structure. I keep thinking we could generate the tests from the defined endpoints, but if we generate it it doesn't make sense to have the tests. I think we want to have a table of Endpoint -> Request, something like a bin/rails routes and compare that with the API instead of testing everything manually. I think what we want is to answer the question: "What can the client do and how does it compare to what the API can do?" and I think and the current way is not the best.

ans-ioki pushed a commit that referenced this issue Nov 2, 2021
@A5308Y
Copy link
Collaborator

A5308Y commented Nov 3, 2021

"me" = me in this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants