fix: secure cookies often are not set by the cookie plugin #7261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensodemann
requested review from
jcesarmobile,
andredestro,
markemer,
nflsilva,
theproducer and
giralte-ionic
giralte-ionic
approved these changes
Mar 15, 2024
|
@dtarnawsky Do you have a good way to replicate this in iOS? |
No, I dont believe it can be done in iOS without being about to set the scheme to https (see slack conversation in ask-capacitor-runtime). |
ItsChaceD
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secure cookies often are not set by the cookie plugin. This code correctly sets them.
This code fixes Android. There seems to be problems in iOS as well.