fix(cli): Don't downgrade gradle version on migrate #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
markemer,
theproducer,
nflsilva and
giralte-ionic
giralte-ionic
approved these changes
Apr 5, 2024
theproducer
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since latest Android Studio prompts to update Gradle to 8.4 some users might have updated their apps already.
Capacitor 6 will use 8.2.1 by default, the migrate command is downgrading the Gradle version if the user already updated.
This PR checks the Gradle wrapper version and avoids the update if the existing version is newer than 8.2.1.
Removed the
updateGradleWrapperfunction because it's not needed,updateGradleWrapperFilesalready updates it, but moved it to be run first as updating the Gradle plugin before the Gradle wrapper it can cause update failures if the plugin version is incompatible with the wrapper version.