Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modal animations regardless of the platform #28499

Closed
3 tasks done
reslear opened this issue Nov 9, 2023 · 2 comments · May be fixed by #28464
Closed
3 tasks done

feat: modal animations regardless of the platform #28499

reslear opened this issue Nov 9, 2023 · 2 comments · May be fixed by #28464
Labels

Comments

@reslear
Copy link

reslear commented Nov 9, 2023

Prerequisites

Describe the Feature Request

for example to make md or ios animations regardless of the platform:

  1. solution - export default animations:
    refactor: exportable md animations for modal #28464
import { mdEnterModalAnimation, mdLeaveModalAnimation } from '@ionic/core'
<ion-modal :enter-animation="mdEnterModalAnimation" :leave-animation="mdLeaveModalAnimation" />
  1. add presets for attribute enter-animation and leave-animation:
//before 
((baseEl: any, opts?: any) => Animation)  undefined

// after 
((baseEl: any, opts?: any) => Animation)  'md' | 'ios'  undefined

Describe the Use Case

Describe Preferred Solution

No response

Describe Alternatives

No response

Related Code

No response

Additional Information

No response

@liamdebeasi
Copy link
Contributor

Thanks for the report. I'm going to merge this with #24964 since they are trying to solve the same root problem.

@liamdebeasi liamdebeasi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@liamdebeasi liamdebeasi removed their assignment Nov 9, 2023
Copy link

ionitron-bot bot commented Dec 9, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants