refactor(angular-output-target): split up component proxy code generation #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
changed the title
rwaskiewicz
approved these changes
Oct 3, 2022
packages/angular-output-target/__tests__/generate-angular-component.spec.ts
Outdated
Show resolved
Hide resolved
| const renamedType = `I${componentClassName}${type}`; | ||
| return renamedType | ||
| .replace(new RegExp(`^${src}$`, 'g'), `${dst}`) | ||
| .replace(new RegExp(`([^\\w])${src}([^\\w])`, 'g'), (v, p1, p2) => [p1, dst, p2].join('')); |
There was a problem hiding this comment.
FWIW, I think this can be simplified to:
Suggested change
| .replace(new RegExp(`([^\\w])${src}([^\\w])`, 'g'), (v, p1, p2) => [p1, dst, p2].join('')); | |
| .replace(new RegExp(`(\W)${src}(\W)`, 'g'), (v, p1, p2) => [p1, dst, p2].join('')); |
There was a problem hiding this comment.
I'm going to opt against taking this commit for this PR. If you want to open up another PR to make that isolated change, I can review it 👍 that way in the event of a bug around this code in the future, it will be easier to reason about the timeline of changes.
packages/angular-output-target/src/generate-angular-component.ts
Outdated
Show resolved
Hide resolved
liamdebeasi
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Split from: #298