Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(angular-output-target): remove directivesUtilsFile #315

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

tanner-reits
Copy link
Member

@tanner-reits tanner-reits commented Dec 14, 2022

This commit removes a parameter for the angularOutputTarget() method that was not accessed anywhere in the output generation code.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The directivesUtilsFile target method param was not accessed anywhere in the output code after it ran through the validation method.

Issue URL: N/A

What is the new behavior?

The field is removed

Does this introduce a breaking change?

  • Yes
  • No

The field is not currently doing anything, so users will just need to remove it from the output target config if the Angular wrapper is used.

Other information

This commit removes a parameter for the `angularOutputTarget()` method that was not accessed anywhere in the output generation code
Copy link
Member

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, although since we do change the public signature of the wrapper, this should be considered a breaking change IMO

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to making this a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants