Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
feat(custom-elements): remove deprecated experimental-dist-module
Use `dist-custom-elements-bundle` instead of `experimental-dist-module`
  • Loading branch information
adamdbradley committed Aug 16, 2020
1 parent 86a28ca commit 41189a6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
6 changes: 1 addition & 5 deletions src/compiler/output-targets/output-utils.ts
Expand Up @@ -44,8 +44,7 @@ export const isOutputTargetDistCollection = (o: d.OutputTarget): o is d.OutputTa

export const isOutputTargetDistCustomElements = (o: d.OutputTarget): o is d.OutputTargetDistCustomElements => o.type === DIST_CUSTOM_ELEMENTS;

export const isOutputTargetDistCustomElementsBundle = (o: d.OutputTarget): o is d.OutputTargetDistCustomElementsBundle =>
o.type === DIST_CUSTOM_ELEMENTS_BUNDLE || o.type === EXPERIMENTAL_DIST_MODULE;
export const isOutputTargetDistCustomElementsBundle = (o: d.OutputTarget): o is d.OutputTargetDistCustomElementsBundle => o.type === DIST_CUSTOM_ELEMENTS_BUNDLE;

export const isOutputTargetCopy = (o: d.OutputTarget): o is d.OutputTargetCopy => o.type === COPY;

Expand Down Expand Up @@ -102,7 +101,6 @@ export const DIST = `dist`;
export const DIST_COLLECTION = `dist-collection`;
export const DIST_CUSTOM_ELEMENTS = `dist-custom-elements`;
export const DIST_CUSTOM_ELEMENTS_BUNDLE = `dist-custom-elements-bundle`;
export const EXPERIMENTAL_DIST_MODULE = `experimental-dist-module`;

export const DIST_TYPES = `dist-types`;
export const DIST_HYDRATE_SCRIPT = `dist-hydrate-script`;
Expand All @@ -124,7 +122,6 @@ export const VALID_TYPES = [
DIST,
DIST_COLLECTION,
DIST_CUSTOM_ELEMENTS,
EXPERIMENTAL_DIST_MODULE,
DIST_GLOBAL_STYLES,
DIST_HYDRATE_SCRIPT,
DIST_LAZY,
Expand All @@ -144,7 +141,6 @@ export const VALID_TYPES_NEXT = [
DIST_COLLECTION,
// DIST_CUSTOM_ELEMENTS,
DIST_CUSTOM_ELEMENTS_BUNDLE,
EXPERIMENTAL_DIST_MODULE,
DIST_LAZY,
DIST_HYDRATE_SCRIPT,

Expand Down
3 changes: 1 addition & 2 deletions src/declarations/stencil-public-compiler.ts
Expand Up @@ -1791,8 +1791,7 @@ export interface OutputTargetDistCustomElements extends OutputTargetBaseNext {
}

export interface OutputTargetDistCustomElementsBundle extends OutputTargetBaseNext {
// dist-custom-elements-bundle
type: 'dist-custom-elements-bundle' | 'experimental-dist-module';
type: 'dist-custom-elements-bundle';
empty?: boolean;
externalRuntime?: boolean;
copy?: CopyTask[];
Expand Down
2 changes: 1 addition & 1 deletion test/end-to-end/stencil.config.ts
Expand Up @@ -34,7 +34,7 @@ export const config: Config = {
type: 'dist',
},
{
type: 'experimental-dist-module',
type: 'dist-custom-elements-bundle',
},
reactOutputTarget({
componentCorePackage: '@stencil/e2e-react-output-target',
Expand Down

0 comments on commit 41189a6

Please sign in to comment.