From 41189a6ab0c8e6e65fca86ac16fe843acb22e22b Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Sun, 16 Aug 2020 01:58:35 -0500 Subject: [PATCH] feat(custom-elements): remove deprecated experimental-dist-module Use `dist-custom-elements-bundle` instead of `experimental-dist-module` --- src/compiler/output-targets/output-utils.ts | 6 +----- src/declarations/stencil-public-compiler.ts | 3 +-- test/end-to-end/stencil.config.ts | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/compiler/output-targets/output-utils.ts b/src/compiler/output-targets/output-utils.ts index b1a38e3b6b3..0e6fe7d4aa7 100644 --- a/src/compiler/output-targets/output-utils.ts +++ b/src/compiler/output-targets/output-utils.ts @@ -44,8 +44,7 @@ export const isOutputTargetDistCollection = (o: d.OutputTarget): o is d.OutputTa export const isOutputTargetDistCustomElements = (o: d.OutputTarget): o is d.OutputTargetDistCustomElements => o.type === DIST_CUSTOM_ELEMENTS; -export const isOutputTargetDistCustomElementsBundle = (o: d.OutputTarget): o is d.OutputTargetDistCustomElementsBundle => - o.type === DIST_CUSTOM_ELEMENTS_BUNDLE || o.type === EXPERIMENTAL_DIST_MODULE; +export const isOutputTargetDistCustomElementsBundle = (o: d.OutputTarget): o is d.OutputTargetDistCustomElementsBundle => o.type === DIST_CUSTOM_ELEMENTS_BUNDLE; export const isOutputTargetCopy = (o: d.OutputTarget): o is d.OutputTargetCopy => o.type === COPY; @@ -102,7 +101,6 @@ export const DIST = `dist`; export const DIST_COLLECTION = `dist-collection`; export const DIST_CUSTOM_ELEMENTS = `dist-custom-elements`; export const DIST_CUSTOM_ELEMENTS_BUNDLE = `dist-custom-elements-bundle`; -export const EXPERIMENTAL_DIST_MODULE = `experimental-dist-module`; export const DIST_TYPES = `dist-types`; export const DIST_HYDRATE_SCRIPT = `dist-hydrate-script`; @@ -124,7 +122,6 @@ export const VALID_TYPES = [ DIST, DIST_COLLECTION, DIST_CUSTOM_ELEMENTS, - EXPERIMENTAL_DIST_MODULE, DIST_GLOBAL_STYLES, DIST_HYDRATE_SCRIPT, DIST_LAZY, @@ -144,7 +141,6 @@ export const VALID_TYPES_NEXT = [ DIST_COLLECTION, // DIST_CUSTOM_ELEMENTS, DIST_CUSTOM_ELEMENTS_BUNDLE, - EXPERIMENTAL_DIST_MODULE, DIST_LAZY, DIST_HYDRATE_SCRIPT, diff --git a/src/declarations/stencil-public-compiler.ts b/src/declarations/stencil-public-compiler.ts index e509f1550a1..4b7577194f7 100644 --- a/src/declarations/stencil-public-compiler.ts +++ b/src/declarations/stencil-public-compiler.ts @@ -1791,8 +1791,7 @@ export interface OutputTargetDistCustomElements extends OutputTargetBaseNext { } export interface OutputTargetDistCustomElementsBundle extends OutputTargetBaseNext { - // dist-custom-elements-bundle - type: 'dist-custom-elements-bundle' | 'experimental-dist-module'; + type: 'dist-custom-elements-bundle'; empty?: boolean; externalRuntime?: boolean; copy?: CopyTask[]; diff --git a/test/end-to-end/stencil.config.ts b/test/end-to-end/stencil.config.ts index 2bf5afdb5a4..efaf7724d54 100644 --- a/test/end-to-end/stencil.config.ts +++ b/test/end-to-end/stencil.config.ts @@ -34,7 +34,7 @@ export const config: Config = { type: 'dist', }, { - type: 'experimental-dist-module', + type: 'dist-custom-elements-bundle', }, reactOutputTarget({ componentCorePackage: '@stencil/e2e-react-output-target',