fix(runtime): forceUpdate calls only execute when in a browser env (#…

…4591) * `forceUpdate` calls only execute when in a browser env * update testing platform build conditionals * fmt * fix an e2e test
ionic-team · Aug 1, 2023 · b203263 · b203263
1 parent e32583a
commit b203263
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/src/runtime/test/globals.spec.tsx b/src/runtime/test/globals.spec.tsx
@@ -33,9 +33,10 @@ describe('globals', () => {
   });
 
   it('build values', () => {
-    expect(Build.isBrowser).toBe(false);
+    expect(Build.isBrowser).toBe(true);
     expect(Build.isDev).toBe(true);
     expect(Build.isTesting).toBe(true);
+    expect(Build.isServer).toBe(false);
   });
 
   it('Env is defined', () => {

diff --git a/src/runtime/update-component.ts b/src/runtime/update-component.ts
@@ -1,5 +1,5 @@
 import { BUILD, NAMESPACE } from '@app-data';
-import { consoleError, doc, getHostRef, nextTick, plt, win, writeTask } from '@platform';
+import { Build, consoleError, doc, getHostRef, nextTick, plt, win, writeTask } from '@platform';
 import { CMP_FLAGS, HOST_FLAGS } from '@utils';
 
 import type * as d from '../declarations';
@@ -362,7 +362,7 @@ export const postUpdateComponent = (hostRef: d.HostRef) => {
 };
 
 export const forceUpdate = (ref: any) => {
-  if (BUILD.updatable) {
+  if (BUILD.updatable && Build.isBrowser) {
     const hostRef = getHostRef(ref);
     const isConnected = hostRef.$hostElement$.isConnected;
     if (

diff --git a/src/testing/platform/testing-build.ts b/src/testing/platform/testing-build.ts
@@ -2,7 +2,7 @@ import type * as d from '@stencil/core/internal';
 
 export const Build: d.UserBuildConditionals = {
   isDev: true,
-  isBrowser: false,
-  isServer: true,
+  isBrowser: true,
+  isServer: false,
   isTesting: true,
 };
diff --git a/test/end-to-end/src/build-data/build-data.spec.ts b/test/end-to-end/src/build-data/build-data.spec.ts
@@ -1,6 +1,7 @@
-import { BuildData } from './build-data';
 import { newSpecPage } from '@stencil/core/testing';
 
+import { BuildData } from './build-data';
+
 describe('build-data', () => {
   it('should be a test', async () => {
     const { root } = await newSpecPage({
@@ -10,7 +11,7 @@ describe('build-data', () => {
     expect(root).toEqualHtml(`
       <build-data>
         <p>isDev: true</p>
-        <p>isBrowser: false</p>
+        <p>isBrowser: true</p>
         <p>isTesting: true</p>
       </build-data>
     `);