feat(config): do not build es5 by default

Do not create the systemjs/es5 builds by default when in prod mode. To get the same default prod builds as Stencil 1, set config.buildEs5 to true to opt-in for the systemjs/es5 builds.
ionic-team · Aug 4, 2020 · fa67d97 · fa67d97
1 parent 363bf59
commit fa67d97
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/compiler/config/test/validate-config.spec.ts b/src/compiler/config/test/validate-config.spec.ts
@@ -86,14 +86,15 @@ describe('validation', () => {
       expect(config.buildEs5).toBe(true);
     });
 
-    it('prod mode default to both es2017 and es5', () => {
+    it('prod mode, set modern and es5', () => {
       userConfig.devMode = false;
+      userConfig.buildEs5 = true;
       const { config } = validateConfig(userConfig);
       expect(config.buildEs5).toBe(true);
     });
 
-    it('dev mode default to only es2017', () => {
-      userConfig.devMode = true;
+    it('prod mode default to only modern and not es5', () => {
+      userConfig.devMode = false;
       const { config } = validateConfig(userConfig);
       expect(config.buildEs5).toBe(false);
     });

diff --git a/src/compiler/config/validate-config.ts b/src/compiler/config/validate-config.ts
@@ -41,13 +41,14 @@ export const validateConfig = (userConfig?: Config) => {
   config.extras.initializeNextTick = !!config.extras.initializeNextTick;
   config.extras.tagNameTransform = !!config.extras.tagNameTransform;
 
+  config.buildEs5 = !!config.buildEs5;
+
   setBooleanConfig(config, 'minifyCss', null, !config.devMode);
   setBooleanConfig(config, 'minifyJs', null, !config.devMode);
   setBooleanConfig(config, 'sourceMap', null, false);
   setBooleanConfig(config, 'watch', 'watch', false);
   setBooleanConfig(config, 'minifyCss', null, !config.devMode);
   setBooleanConfig(config, 'minifyJs', null, !config.devMode);
-  setBooleanConfig(config, 'buildEs5', 'es5', !config.devMode);
   setBooleanConfig(config, 'buildDocs', 'docs', !config.devMode);
   setBooleanConfig(config, 'buildDist', 'esm', !config.devMode || config.buildEs5);
   setBooleanConfig(config, 'profile', 'profile', config.devMode);