feat(test): remove deprecated testing configs

ionic-team · Aug 4, 2020 · fb8a02b · fb8a02b
1 parent b5cba6a
commit fb8a02b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 14 deletions.
diff --git a/src/compiler/config/validate-testing.ts b/src/compiler/config/validate-testing.ts
@@ -1,5 +1,5 @@
 import * as d from '../../declarations';
-import { buildError, buildWarn, isString } from '@utils';
+import { buildError, isString } from '@utils';
 import { isAbsolute, join, basename, dirname } from 'path';
 import { isLocalModule } from '../sys/resolve/resolve-utils';
 import { isOutputTargetDist, isOutputTargetWww } from '../output-targets/output-utils';
@@ -84,10 +84,6 @@ export const validateTesting = (config: d.Config, diagnostics: d.Diagnostic[]) =
   }
 
   testing.setupFilesAfterEnv.unshift(join(config.sys.getCompilerExecutingPath(), '..', '..', 'testing', 'jest-setuptestframework.js'));
-  if (testing.setupTestFrameworkScriptFile) {
-    const err = buildWarn(diagnostics);
-    err.messageText = `setupTestFrameworkScriptFile has been deprecated.`;
-  }
 
   if (isString(testing.testEnvironment)) {
     if (!isAbsolute(testing.testEnvironment) && isLocalModule(testing.testEnvironment)) {

diff --git a/src/declarations/stencil-public-compiler.ts b/src/declarations/stencil-public-compiler.ts
@@ -1454,10 +1454,6 @@ export interface JestConfig {
 
   setupFilesAfterEnv?: string[];
 
-  /**
-   * @deprecated Use setupFilesAfterEnv instead.
-   */
-  setupTestFrameworkScriptFile?: string;
   snapshotSerializers?: any[];
   testEnvironment?: string;
   testEnvironmentOptions?: any;

diff --git a/src/testing/spec-page.ts b/src/testing/spec-page.ts
@@ -126,11 +126,6 @@ export async function newSpecPage(opts: NewSpecPageOptions): Promise<SpecPage> {
   BUILD.safari10 = false;
   BUILD.attachStyles = !!opts.attachStyles;
 
-  (page as any).flush = () => {
-    console.warn(`DEPRECATED: page.flush(), please use page.waitForChanges() instead`);
-    return page.waitForChanges();
-  };
-
   if (typeof opts.url === 'string') {
     page.win.location.href = opts.url;
   }