From fb8a02b4be0f7214d131e7c228964ca8423c3be0 Mon Sep 17 00:00:00 2001 From: Adam Bradley Date: Tue, 4 Aug 2020 14:02:56 -0500 Subject: [PATCH] feat(test): remove deprecated testing configs --- src/compiler/config/validate-testing.ts | 6 +----- src/declarations/stencil-public-compiler.ts | 4 ---- src/testing/spec-page.ts | 5 ----- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/src/compiler/config/validate-testing.ts b/src/compiler/config/validate-testing.ts index 898fb768b99..6779d03febf 100644 --- a/src/compiler/config/validate-testing.ts +++ b/src/compiler/config/validate-testing.ts @@ -1,5 +1,5 @@ import * as d from '../../declarations'; -import { buildError, buildWarn, isString } from '@utils'; +import { buildError, isString } from '@utils'; import { isAbsolute, join, basename, dirname } from 'path'; import { isLocalModule } from '../sys/resolve/resolve-utils'; import { isOutputTargetDist, isOutputTargetWww } from '../output-targets/output-utils'; @@ -84,10 +84,6 @@ export const validateTesting = (config: d.Config, diagnostics: d.Diagnostic[]) = } testing.setupFilesAfterEnv.unshift(join(config.sys.getCompilerExecutingPath(), '..', '..', 'testing', 'jest-setuptestframework.js')); - if (testing.setupTestFrameworkScriptFile) { - const err = buildWarn(diagnostics); - err.messageText = `setupTestFrameworkScriptFile has been deprecated.`; - } if (isString(testing.testEnvironment)) { if (!isAbsolute(testing.testEnvironment) && isLocalModule(testing.testEnvironment)) { diff --git a/src/declarations/stencil-public-compiler.ts b/src/declarations/stencil-public-compiler.ts index 7a1c0c85029..f9a50e17b0b 100644 --- a/src/declarations/stencil-public-compiler.ts +++ b/src/declarations/stencil-public-compiler.ts @@ -1454,10 +1454,6 @@ export interface JestConfig { setupFilesAfterEnv?: string[]; - /** - * @deprecated Use setupFilesAfterEnv instead. - */ - setupTestFrameworkScriptFile?: string; snapshotSerializers?: any[]; testEnvironment?: string; testEnvironmentOptions?: any; diff --git a/src/testing/spec-page.ts b/src/testing/spec-page.ts index 9f4afe8ef1e..c659d978dac 100644 --- a/src/testing/spec-page.ts +++ b/src/testing/spec-page.ts @@ -126,11 +126,6 @@ export async function newSpecPage(opts: NewSpecPageOptions): Promise { BUILD.safari10 = false; BUILD.attachStyles = !!opts.attachStyles; - (page as any).flush = () => { - console.warn(`DEPRECATED: page.flush(), please use page.waitForChanges() instead`); - return page.waitForChanges(); - }; - if (typeof opts.url === 'string') { page.win.location.href = opts.url; }