Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stenciljs/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.17.3
Choose a base ref
...
head repository: stenciljs/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.17.4
Choose a head ref
  • 10 commits
  • 68 files changed
  • 2 contributors

Commits on Aug 5, 2022

  1. chore(config): use ValidatedConfig in output-targets/ (#3496)

    this commit propagates the usage of `ValidatedConfig` throughout the
    `output-targets/` directory. This is being done following making `sys` a
    required field on `ValidatedConfig` in 991843a
    (#3491), where driving down the number of `sys`-related violations of the compile
    time check is the primary driver.  however, this commit does also lay groundwork
    for future fields being made required on the validated config, and require less
    proliferation of the type in the future.
    
    all output target types were updated in this commit. that includes the legacy angular
    output target, and the custom elements bundle output target. both of the aforementioned
    targets are intended to be deprecated/removed in stencil v3. however, the level of effort
    required to proliferate the change provides us with a more accurate count of
    `strictNullChecks` violations, and does not require waiting for a major version bump of
    stencil to drive the violation count further
    rwaskiewicz authored Aug 5, 2022
    Copy the full SHA
    100e6fc View commit details
  2. chore(config): propagate ValidatedConfig to output target validation (#…

    …3497)
    
    this commit propagates the usage of `ValidatedConfig` throughout the
    portion of the code that validates an output target defintion from a
    configuration. This is being done following making sys a
    required field on ValidatedConfig in 991843a
    (#3491), where driving down the number of sys-related violations of
    the compile time check is the primary driver. however, this commit
    does also lay groundwork for future fields being made required on the
    validated config, and require less proliferation of the type in the
    future.
    
    all output target validations were updated in this commit. the
    validations for the legacy angular output target, and the custom
    elements bundle output target. both of the aforementioned targets are
    intended to be deprecated/removed in stencil v3. however, the level of
    effort required to proliferate the change provides us with a more
    accurate count of strictNullChecks violations, and does not require
    waiting for a major version bump of stencil to drive the violation
    count further
    rwaskiewicz authored Aug 5, 2022
    Copy the full SHA
    10421be View commit details
  3. chore(config): migrate additional callsites to ValidatedConfig (#3498)

    this commit propagates the usage of `ValidatedConfig` throughout
    various parts of the code. the changes are distributed and small in size,
    which made it feel unnecessary to split into multiple pull requests, given
    the nature of the changes being proposed.
    
    this is being done following making sys a required field on ValidatedConfig
    in 991843a (#3491), where driving down the number of sys-related violations of
    the compile time check is the primary driver.
    rwaskiewicz authored Aug 5, 2022
    Copy the full SHA
    c185d02 View commit details
  4. chore(config): make testing property required field (#3509)

    this commit updates `ValidatedConfig` in order to make the `testing`
    field required. this is being done in pursuit of dropping the number of
    `strictNullChecks` violations in the code, and was a side task of
    stencil-501 (the author of this commit was actively in the testing code,
    making it a good opportunity to knock this out).
    
    this commit makes `testing` default to an empty object literal, rather
    than `null` or pre-populating existing fields. choosing the former would
    require additional optional checks throughout the code (which assumes
    `testing` is a defined field, and choosing the latter would expand the
    scope of this commit vastly. an empty object literal should incur
    minimal runtime overhead, while keeping the size/scope of this commit to
    a minimal
    rwaskiewicz authored Aug 5, 2022
    Copy the full SHA
    8d2cbea View commit details

Commits on Aug 15, 2022

  1. fix(task): consider config sys in task runner (#3518)

    this commit updates the generation of a `ValidatedConfig` entity to take
    a `sys` property on a user provided `Config` in the context of
    `runTask`.
    
    when generating the validated configuration, the `sys` entity takes
    precedence over all other configurations, with the belief that in the
    event argument was provided, it is the intent of the user to use it. in
    the event `sys` is not expressly provided, use the one on the provided
    configuration entity. this is useful in the case that a user used
    stencil's external facing apis in a flow that:
    1. loads a configuration
    2. validates that configuration
    3. uses that configuration when calling `runTask` directly
    
    this commit fixes a bug introduced making `sys` a required field on
    `ValidatedConfig`, where `config.sys` was not properly accounted for.
    the bug was initially introduced in
    a6a9171 (#3491)
    rwaskiewicz authored Aug 15, 2022
    Copy the full SHA
    103ec60 View commit details
  2. fix(compiler): don't break HMR by mangling CSS (#3517)

    This fixes an issue (#3461) where CSS is being inappropriately mangled
    when using the hot-reload dev server. The issue has details about
    exactly what the problem is, but basically in short if you are using the
    `dist-hydrate-script` output target and running the dev server then any
    change to a CSS file will cause all styling to be wiped from the related
    component in the browser, making for a pretty inadequate developer
    experience.
    
    This commit fixes the issue by changing the conditions under which
    original CSS selectors are commented out
    alicewriteswrongs authored Aug 15, 2022
    Copy the full SHA
    f5b2b69 View commit details

Commits on Aug 18, 2022

  1. chore(tests): fix null check errors for jest preprocess (#3526)

    this commit removes a handful of strict null check violations that can
    be found in stencil's jest preprocessor. most changes are concerned with
    making types agree - e.g. if a variable is declared to be of type `T`,
    but is assigned by a function that returns `T | U`, the type of the
    variable is expanded for agreement.
    
    the two changes that are worth calling out in particular is introducing
    a `throw` statement in the event that the `transformOptions` parameter
    is falsy both when we process a file and attempt to retrieve a cache
    key. from jest 23 thru 27, the function signatures of these two
    functions changed a few times (documented in the code today). however,
    a typing issue that was introduced in
    e0640de (#3171) was `transformOptions`
    could be considered `undefined` by typescript. we know that for jest
    [23,26], this value will never be falsy (as it is a part of the call
    signature). for jest 27, we re-assign a value to this variable for
    backwards compatibility reasons.
    
    there is a high level of confidence that this `throw` is safe to
    introduce for the following reasons:
    1. if `transformOptions` is undefined/null, stencil would already be
       erroring out when running the test task
    2. the function signatures changes of these two functions have been
       handled in e0640de
    3. in jest [23,26], `transformOptions` _always_ has a `rootDir` field of
       type `string` (which is the field we're accessing here causing
       errors)
    rwaskiewicz authored Aug 18, 2022
    Copy the full SHA
    7f8e5c6 View commit details
  2. chore(cli): add types to finding config (#3527)

    this commit adds additional types for the function that finds a user's
    configuration file on disk in the hope of adding clarity and removing a
    type assertion in the function
    rwaskiewicz authored Aug 18, 2022
    Copy the full SHA
    9132a76 View commit details

Commits on Aug 19, 2022

  1. chore(github): print uncommitted files for browserstack (#3531)

    this commit updates the "Git status check" step
    of the browserstack workflow to print the names
    of the files that are uncommitted
    rwaskiewicz authored Aug 19, 2022
    Copy the full SHA
    e6c8078 View commit details

Commits on Aug 22, 2022

  1. 🐞 v2.17.4

    rwaskiewicz committed Aug 22, 2022
    Copy the full SHA
    214e981 View commit details
Loading