-
Notifications
You must be signed in to change notification settings - Fork 800
Comparing changes
Open a pull request
base repository: stenciljs/core
base: v4.0.1
head repository: stenciljs/core
compare: v4.0.2
Commits on Jun 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3cda014 - Browse repository at this point
Copy the full SHA 3cda014View commit details -
chore(deps): update dependency conventional-changelog-cli to v3 (#4480)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2a0a3bb - Browse repository at this point
Copy the full SHA 2a0a3bbView commit details
Commits on Jun 30, 2023
-
chore(deps): update dependency @types/node to v20.3.2 (#4531)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for aa46300 - Browse repository at this point
Copy the full SHA aa46300View commit details
Commits on Jul 3, 2023
-
chore(deps): update dependency puppeteer to v20.7.4 (#4534)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fc5e383 - Browse repository at this point
Copy the full SHA fc5e383View commit details -
chore(deps): update dependency webpack to v5.88.1 (#4536)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6e8ae69 - Browse repository at this point
Copy the full SHA 6e8ae69View commit details -
chore(deps): update dependency terser to v5.18.2 (#4535)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bdcc2e7 - Browse repository at this point
Copy the full SHA bdcc2e7View commit details -
chore(deps): update typescript-eslint to v5.60.1 (#4537)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6d8e45e - Browse repository at this point
Copy the full SHA 6d8e45eView commit details -
chore(deps): update dependency eslint-plugin-jsdoc to v46.4.2 (#4538)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 35816fb - Browse repository at this point
Copy the full SHA 35816fbView commit details
Commits on Jul 5, 2023
-
chore(deps): update dependency eslint to v8.44.0 (#4542)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 045d4b4 - Browse repository at this point
Copy the full SHA 045d4b4View commit details -
chore(deps): update dependency @types/node to v20.3.3 (#4541)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e86c3d6 - Browse repository at this point
Copy the full SHA e86c3d6View commit details
Commits on Jul 6, 2023
-
chore(deps): update actions/setup-node action to v3.7.0 (#4546)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4cd142f - Browse repository at this point
Copy the full SHA 4cd142fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9e4e1a - Browse repository at this point
Copy the full SHA d9e4e1aView commit details
Commits on Jul 7, 2023
-
chore(deps): update dependency magic-string to v0.30.1 (#4549)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 472dee1 - Browse repository at this point
Copy the full SHA 472dee1View commit details
Commits on Jul 10, 2023
-
chore(deps): update node.js to v20.4.0 (#4561)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f21d56b - Browse repository at this point
Copy the full SHA f21d56bView commit details -
chore(deps): update dependency puppeteer to v20.8.0 (#4560)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9b78077 - Browse repository at this point
Copy the full SHA 9b78077View commit details -
chore(deps): update dependency @types/node to v20.4.0 (#4558)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 145739d - Browse repository at this point
Copy the full SHA 145739dView commit details -
chore(deps): update typescript-eslint to v5.61.0 (#4562)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 18847ad - Browse repository at this point
Copy the full SHA 18847adView commit details -
chore(deps): bump tough-cookie from 4.1.2 to 4.1.3 (#4555)
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2832cf2 - Browse repository at this point
Copy the full SHA 2832cf2View commit details -
chore(deps): update dependency postcss to v8.4.25 (#4557)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f87cb3e - Browse repository at this point
Copy the full SHA f87cb3eView commit details -
chore(deps): update dependency eslint-plugin-jsdoc to v46.4.3 (#4556)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1f518fb - Browse repository at this point
Copy the full SHA 1f518fbView commit details -
chore(deps): update dependency npm to v9.8.0 (#4559)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b001be0 - Browse repository at this point
Copy the full SHA b001be0View commit details
Commits on Jul 11, 2023
-
chore(deps): update dependency semver to v7.5.4 (#4565)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 20fd100 - Browse repository at this point
Copy the full SHA 20fd100View commit details -
chore(deps): update dependency @types/eslint to v8.44.0 (#4566)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a52f6fc - Browse repository at this point
Copy the full SHA a52f6fcView commit details -
chore(deps): update dependency @types/node to v20.4.1 (#4564)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 30e5ffc - Browse repository at this point
Copy the full SHA 30e5ffcView commit details
Commits on Jul 13, 2023
-
chore(repo): minimize component starter test pack (#4520)
* chore(repo): minimize component starter test pack this commit minimizes the number of files included in `npm pack` when running the stencil component starter smoke tests. previously, files would get added to the binary that would either be unnecessary, or would not be representative of an actual stencil release. these include: - `build/`, an artifact of building stencil itself. this isn't needed at all, and has been removed from the build archive - `node_modules/` would get implicitly linked by `npm pack`, which get deleted now prior to running the command a side effect of this work is that we now compartmentalize the building of the stencil tarball (as opposed to generating a dev build for every run of ci and pushing that to a registry). this makes the chances of accidentally picking the wrong file when running `npm pack` and renaming it lower. STENCIL-850 Investigate Component Starter Issues in CI STENCIL-688 Revisit Logic for Component Starter Tests * refactor(compiler): add a Result union type for polymorphic returns (#4281) This adds a new way to handle return types like those of the `generateBuildStatus` function. See here for some previous conversation about this: #3383 (comment) At present in `main` this function returns `d.CompilerBuildStats | { diagnostics: d.Diagnostic[] }`: https://github.com/ionic-team/stencil/blob/b5dc6d533f7961641e4876fe3411834884748b2f/src/compiler/build/build-stats.ts#L11-L14 We use this sort of pattern in a few places throughout the codebase, where basically if a function could generate diagnostic messages it will return either it's 'normal' return value _or_ an object holding those diagnostics. We then typically have some manual checking to see which of the two it is, or perhaps just a type assertion. This pattern works alright, but in looking at this code before we identified it as something we'd like to clean up in the future. To do so, this commit introduces a new `Result` union type which is either an `Ok` or an `Err`. It's quite obviously strongly inspired by the `Result` enum in Rust's standard library (https://doc.rust-lang.org/std/result/) and it lets us handle two possible return values, one for the 'happy path' and one indicating something didn't go right, in a principled way. Using it looks something like this: ```ts import { result } from "@utils"; const myFunc = (): result.Result<string, string> { if (failing) { return result.err("I failed!"); } else { return result.ok("I succeeded!"); } } ``` Once you have a value of type `Result` there are some helper methods similar to what you might be familiar with in Rust like a `result.map`. * Revert "refactor(compiler): add a Result union type for polymorphic returns (#4281)" This reverts commit e71e9b3. --------- Co-authored-by: Alice <alice.writes.wrongs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 538766b - Browse repository at this point
Copy the full SHA 538766bView commit details -
fix(rollup-config): deprecate BundlingConfig#namedExports (#4532)
this commit deprecates the `namedExports` field on the `BundlingConfig` interface. `@rollup/plugin-commonjs` no longer honors this field as of rollup/plugins@5d2dcf4. Fixes: #2523 STENCIL-867
Configuration menu - View commit details
-
Copy full SHA for a353769 - Browse repository at this point
Copy the full SHA a353769View commit details -
fix(runtime): properly type color-interpolation-filter (#4530)
this commit updates the typings of `SVGAttributes#color-interpolation-filter` to match the current spec, which states the only accepted values are 'auto', 'sRGB' and 'linearRGB'. this commit renames 's-rGB' to 'sRGB' and 'linear-rGB' to 'linearRGB'. it also removes 'inherit'. it is believed this was done by accident in a regex-based replacement of camelCased properties to kebab-cased attributes in 667597d
Configuration menu - View commit details
-
Copy full SHA for 3ccf753 - Browse repository at this point
Copy the full SHA 3ccf753View commit details -
test(validate-testing): test when no flags are provided (#4540)
this commit adds tests for valdiating stencil's testing configuration when no flags are provided to the testing validation function. this changeset was intended to be added in #4384, but for some reason was missed
Configuration menu - View commit details
-
Copy full SHA for 5f436af - Browse repository at this point
Copy the full SHA 5f436afView commit details -
fix(compiler): sourcemap errors for dist-custom-elements + dist-hydra…
…te-script (#4527) this commit fixes an issue where a stencil project that use both the `dist-custom-elements` and `dist-hydrate-script` output targets would see the following error when building their project (with sourcemaps enabled): ``` [ WARN ] Bundling Warning SOURCEMAP_ERROR Error when using sourcemap for reporting an error: Can't resolve original location of error. ``` this commit resolves this error by ensuring the `HTMLElement` core runtime API used by `dist-custom-elements` no longer interferese with the generated code for `dist-hydrate-script`. this is accomplished by using the output-target-specific runtime api slots introduced in #4200. this prevents the `HTMLElement` import from polluting the sourcemaps/source used in the `dist-hydrate-script` target
Configuration menu - View commit details
-
Copy full SHA for 1d79672 - Browse repository at this point
Copy the full SHA 1d79672View commit details -
refactor(compiler): remove requireFunc (#4568)
Now that we're node-only for compiling components we don't need this any longer (or, put another way, it's just become an alias for `require` anyway)
Configuration menu - View commit details
-
Copy full SHA for 01d7a9e - Browse repository at this point
Copy the full SHA 01d7a9eView commit details -
fix(compiler): sourcemap generation without ext runtime (#4570)
* fix(compiler): sourcemap generation for non-external runtime this commit fixes a bug where projects using the `dist-custom-elements` output target with `externalRuntime: false` would receive the following error when building their project: ``` [ WARN ] Bundling Warning SOURCEMAP_ERROR Error when using sourcemap for reporting an error: Can't resolve original location of error. ``` the cause of this error was attempting to import a function, `attachShadow` that is no longer exported from the runtime bundle (as of #3117). to date, this has not had an effect on stencil (as the import gets treeshaken away). however, when trying to generate sourcemaps for a project using this configuration would cause a mismatch between what was expected to be in the produced output (the import statement) and what was really there (no import statement) * refactor(compiler): remove unused ATTACH_SHADOW API this commit removes the RUNTIME_APIS.ATTACH_SHADOW field that is no longer used in the codebase. it's only usage was in tests for adding runtime apis, and has been replaced with another field from `RUNTIME_APIS`
Configuration menu - View commit details
-
Copy full SHA for d1be334 - Browse repository at this point
Copy the full SHA d1be334View commit details
Commits on Jul 14, 2023
-
refactor(environment): remove IS_NODE_ENV and delete dead code (#4551)
* refactor(environment): remove IS_NODE_ENV and delete dead code This removes the `IS_NODE_ENV` variable from our environment module which previously was used to switch between browser-specific and node-specific approaches to various things in the Stencil compilation process. Following the merge of #4317 we only support one runtime, node, for compiling Stencil components, so we can assume that `IS_NODE_ENV` is `true` and delete code accordingly. * refactor(environment): remove IS_BROWSER_ENV and delete dead code This removes the `IS_BROWSER_ENV` from our environment module. Previously this was used to signal when Stencil was being used to compile components in a browser environment. After we removed support for that functionality in #4317 we don't need the variable any longer, so we can assume that `IS_BROWSER_ENV` is `false` and delete dead code accordingly.
Configuration menu - View commit details
-
Copy full SHA for 445fc4f - Browse repository at this point
Copy the full SHA 445fc4fView commit details -
fix(output-targets): fix path normalization logic (#4545)
In #4317 as part of removing in-browser compilation support we removed the polyfills for nodejs built-in modules like `path` which were injected by Rollup during build-time. Although the _main_ purpose of these polyfills was allowing Stencil to run in the browser in the case of the `path` module there was also a secondary purpose which was ensuring that paths were treated the same way across supported platforms (posix + windows). See, for instance, the following lines in the polyfill: https://github.com/ionic-team/stencil/blob/b911f1986a0d583bd1e3cd42cbbca9b255c32f2d/src/compiler/sys/modules/path.ts#L35-L38 These functions basically wrapped the existing path implementation with our `normalizePath` helper, which would ensure that the output paths would be the same on both windows and posix systems (e.g. macOS and linux). When we merged #4317 an effort was made to add `normalizePath` around the codebase where it was thought that various paths being calculated needed to be platform-independent, however, a few locations were missed (in particular, some paths output into typedefs, which would show up as non-posix paths when building on windows). To address the issue we introduce `relative` and `join` functions into the existing path-related `utils` file (which is incidentally renamed) which work similarly to how the patched functions in the old polyfill did. Then several usage sites are changed to import those new utils instead of the 'raw' functions from `path`. Together these changes should ensure that Stencil's output is not platform-dependent. See here for an issue reporting the problem: #4543
Configuration menu - View commit details
-
Copy full SHA for cd5849c - Browse repository at this point
Copy the full SHA cd5849cView commit details -
fix(compiler): ensures transformed paths are relative paths for `dist…
…-collection` (#4552) * ensures transformed paths are relative paths * fix test expected path
Configuration menu - View commit details
-
Copy full SHA for e11ac0e - Browse repository at this point
Copy the full SHA e11ac0eView commit details -
fix(compiler): only create one class member when transforming `@Eleme…
…nt()` decorators (#4547) * only create one class member for an `@Element()` * add some regression tests
Configuration menu - View commit details
-
Copy full SHA for 13fac03 - Browse repository at this point
Copy the full SHA 13fac03View commit details
Commits on Jul 17, 2023
-
chore(deps): update dependency @types/node to v20.4.2 (#4577)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0e23326 - Browse repository at this point
Copy the full SHA 0e23326View commit details -
chore(deps): update dependency eslint-plugin-jest to v27.2.3 (#4578)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1447475 - Browse repository at this point
Copy the full SHA 1447475View commit details -
chore(deps): update dependency puppeteer to v20.8.2 (#4580)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 58f3c66 - Browse repository at this point
Copy the full SHA 58f3c66View commit details -
chore(deps): update dependency postcss to v8.4.26 (#4579)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c0c607e - Browse repository at this point
Copy the full SHA c0c607eView commit details -
chore(deps): update typescript-eslint to v5.62.0 (#4582)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 58b3acb - Browse repository at this point
Copy the full SHA 58b3acbView commit details -
chore(deps): update dependency terser to v5.19.0 (#4581)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 42a031f - Browse repository at this point
Copy the full SHA 42a031fView commit details -
chore(deps): update dependency prettier to v3 (#4563)
* chore(deps): update dependency prettier to v3 * update @ionic/prettier-config so prettier can go to v3 * run prettier v3 * deal with prettier upgrade fallout * have to do that for windows :/ * lol * undo that change * update jest path this commit works on windows, we'll see if unix does too --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Alice Pote <alice.writes.wrongs@gmail.com> Co-authored-by: Ryan Waskiewicz <waskiewicz@ionic.io>
Configuration menu - View commit details
-
Copy full SHA for efc3b22 - Browse repository at this point
Copy the full SHA efc3b22View commit details -
fix(compiler): handle
@supports
blocks when scoping css (#4572)* ignore `@supports` rules in "polyfill" replacements * update regex to work with multiple selectors on a line * handle entire css rule as a single line * add unit tests for `@supports` rules * add detail to regex matches
Configuration menu - View commit details
-
Copy full SHA for 18ed5fc - Browse repository at this point
Copy the full SHA 18ed5fcView commit details
Commits on Jul 18, 2023
-
chore(deps): update dependency eslint to v8.45.0 (#4585)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a55a5a5 - Browse repository at this point
Copy the full SHA a55a5a5View commit details -
refactor(compiler): add a Result union type for polymorphic returns (#…
…4573) This commit was initially added in #4281 and then reverted in #4415. This adds a new way to handle return types like those of the `generateBuildStatus` function. See here for some previous conversation about this: At present in `main` this function returns `d.CompilerBuildStats | { diagnostics: d.Diagnostic[] }`: https://github.com/ionic-team/stencil/blob/b5dc6d533f7961641e4876fe3411834884748b2f/src/compiler/build/build-stats.ts#L11-L14 We use this sort of pattern in a few places throughout the codebase, where basically if a function could generate diagnostic messages it will return either it's 'normal' return value _or_ an object holding those diagnostics. We then typically have some manual checking to see which of the two it is, or perhaps just a type assertion. This pattern works alright, but in looking at this code before we identified it as something we'd like to clean up in the future. To do so, this commit introduces a new `Result` union type which is either an `Ok` or an `Err`. It's quite obviously strongly inspired by the `Result` enum in Rust's standard library (https://doc.rust-lang.org/std/result/) and it lets us handle two possible return values, one for the 'happy path' and one indicating something didn't go right, in a principled way. Using it looks something like this: ```ts import { result } from "@utils"; const myFunc = (): result.Result<string, string> { if (failing) { return result.err("I failed!"); } else { return result.ok("I succeeded!"); } } ``` Once you have a value of type `Result` there are some helper methods similar to what you might be familiar with in Rust like a `result.map`.
Configuration menu - View commit details
-
Copy full SHA for d5b31ce - Browse repository at this point
Copy the full SHA d5b31ceView commit details -
refactor(compiler): propagate
ValidatedConfig
(#4569)This propagates the `ValidatedConfig` in place of the `Config`, branching out from `src/compiler/transpile.ts`
Configuration menu - View commit details
-
Copy full SHA for 7d5dc6c - Browse repository at this point
Copy the full SHA 7d5dc6cView commit details -
chore(deps): update dependency @ionic/prettier-config to v4 (#4586)
* chore(deps): update dependency @ionic/prettier-config to v4 * fmt(): format code --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d2d0a0 - Browse repository at this point
Copy the full SHA 9d2d0a0View commit details
Commits on Jul 19, 2023
-
fix(lazy): adjust the type of
defineCustomElements
(#4592)This fixes an issue with the type for `defineCustomElements` that we set in output-lazy-loader.ts. In #4419 we changed the return type of the function to be `void` (at runtime) but we didn't make a corresponding adjustment to the type declaration for the function that we generate here: https://github.com/ionic-team/stencil/blob/7d5dc6cf5e0d2020c513cc87b6b2e5b93eece9bc/src/compiler/output-targets/output-lazy-loader.ts#L88 This change adjusts that type declaration to have a `void` return value, instead of `Promise<void>`. See #4589 for more context
Configuration menu - View commit details
-
Copy full SHA for 5c85c33 - Browse repository at this point
Copy the full SHA 5c85c33View commit details -
chore(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (#4593)
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 989b53f - Browse repository at this point
Copy the full SHA 989b53fView commit details
Commits on Jul 21, 2023
-
chore(deps): update dependency terser to v5.19.1 (#4602)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9b0d6b1 - Browse repository at this point
Copy the full SHA 9b0d6b1View commit details
There are no files selected for viewing