Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stenciljs/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.4
Choose a base ref
...
head repository: stenciljs/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.5
Choose a head ref
  • 17 commits
  • 9 files changed
  • 3 contributors

Commits on Aug 7, 2023

  1. chore(deps): update dependency eslint-config-prettier to v8.10.0 (#4656) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 7, 2023
    Copy the full SHA
    f27bcb3 View commit details

  2. chore(deps): update dependency @types/node to v20.4.7 (#4654) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 7, 2023
    Copy the full SHA
    e414813 View commit details

  3. chore(deps): update dependency prettier to v3.0.1 (#4655) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 7, 2023
    Copy the full SHA
    ea563d9 View commit details

  4. chore(deps): update typescript-eslint to v6.2.1 (#4657) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 7, 2023
    Copy the full SHA
    cff7622 View commit details

  5. chore(deps): update dependency puppeteer to v21 (#4658) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 7, 2023
    Copy the full SHA
    4ce38c5 View commit details

Commits on Aug 10, 2023

  1. chore(deps): update dependency @types/eslint to v8.44.2 (#4668) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 10, 2023
    Copy the full SHA
    0e9ef34 View commit details

  2. chore(deps): update dependency @types/node to v20.4.8 (#4669) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 10, 2023
    Copy the full SHA
    90e85da View commit details

  3. chore(deps): update dependency eslint-config-prettier to v9 (#4670) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 10, 2023
    Copy the full SHA
    fce6597 View commit details

Commits on Aug 14, 2023

  1. chore(deps): update typescript-eslint to v6.3.0 (#4680) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 14, 2023
    Copy the full SHA
    0d4c73f View commit details

  2. chore(deps): update dependency puppeteer to v21.0.2 (#4679) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 14, 2023
    Copy the full SHA
    bff7229 View commit details

  3. chore(deps): update dependency @types/node to v20.4.9 (#4677) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 14, 2023
    Copy the full SHA
    1ddffbd View commit details

  4. chore(deps): update dependency eslint-plugin-jsdoc to v46.4.6 (#4678) 

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 14, 2023
    Copy the full SHA
    a62498c View commit details

  5. fix(compiler): match tsconfig include paths properly (#4676) 

    this commit fixes a bug where a user was unable to use relative paths in
the `include` property of their `tsconfig.json` file if `srcDir` was
also specified.

previously, when `tsconfig.json#include` contained a relative path:
```
"include": [
  "./app/javascript"
],
```
and `tsconfig.json#srcDir` included the non-relative version of that path:
```
srcDir: 'app/javascript',
```

then you would receive a very confusing error:
```
[ WARN  ]  tsconfig.json "include" required
           In order for TypeScript to improve watch performance, it's recommended the "tsconfig.json" file should have
           the "include" property, with at least the app's "app/javascript" directory listed. For example: "include":
           ["app/javascript"]
```

closes #4667
    @rwaskiewicz
    rwaskiewicz authored Aug 14, 2023
    Copy the full SHA
    664ecb7 View commit details

  6. chore(repo): split internal and user-facing jest config (#4666) 

    this commit separates stencil's internal testing jest configuration
(used when running unit tests on the stencil project itself), and the
jest configuration used by stencil projects (when a stencil user runs
`npm t` in their project).

with this commit, we remove the inheritance on the jest configuration
that we bundle with stencil for end users. in order to ensure that
stencil's internal tests continue to function, the internal jest config
has been updated to have near parity with the external one. the intent
of this commit is _not_ to optimize the jest config, but rather separate
the two so that we can begin to bring support for newer versions of jest
to end users without dragging out the process (i.e. upgrading ourselves)
    @rwaskiewicz
    rwaskiewicz authored Aug 14, 2023
    Copy the full SHA
    a81c0d5 View commit details

  7. chore(compiler): remove some unused code (#4665) 

    This deletes the code in `src/compiler/sys/worker/web-worker-*.ts`. Both
of the files in that directory which appeared to implement some sort of
web worker-based compilation task runner were unused.
    @alicewriteswrongs
    alicewriteswrongs authored Aug 14, 2023
    Copy the full SHA
    aac37fd View commit details

  8. chore(declarations): remove unused types (#4673) 

    this commit removes several types that are unused in the stencil
codebase. these have previously gone undetected due to their being
exported by `src/declarations/index.ts`.

these types are not used within the stencil codebse. _however_ it is
possible that a consumer is reaching into our internal type declarations
to use these types. those that are in this file are assumed to be
'private' (and therefore volatile). should a bug report come in
regarding one of these types, the recommeneded recourse is that the team
investigate/determine on a per-issue basis whether the type should be
restored in `stencil-public.ts` or re-added to this file and deprecated
(and removed in v5)
    @rwaskiewicz
    rwaskiewicz authored Aug 14, 2023
    Copy the full SHA
    c0085e8 View commit details

  9. 🚣 v4.0.5

    @rwaskiewicz
    rwaskiewicz committed Aug 14, 2023
    Copy the full SHA
    b217b96 View commit details
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## 🚣 [4.0.5](https://github.com/ionic-team/stencil/compare/v4.0.4...v4.0.5) (2023-08-14)


### Bug Fixes

* **compiler:** match tsconfig include paths properly ([#4676](https://github.com/ionic-team/stencil/issues/4676)) ([664ecb7](https://github.com/ionic-team/stencil/commit/664ecb78cba3a267fa436cada551d878655cd2ab)), closes [#4667](https://github.com/ionic-team/stencil/issues/4667)



## 🍧 [4.0.4](https://github.com/ionic-team/stencil/compare/v4.0.3...v4.0.4) (2023-08-07)


13 changes: 10 additions & 3 deletions jest.config.js
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
module.exports = {
preset: './testing/jest-preset.js',
moduleNameMapper: {
'@app-data': '<rootDir>/internal/app-data/index.cjs',
'@app-globals': '<rootDir>/internal/app-globals/index.cjs',
@@ -12,6 +11,8 @@ module.exports = {
'@sys-api-node': '<rootDir>/sys/node/index.js',
'@utils': '<rootDir>/src/utils',
'^typescript$': '<rootDir>/scripts/build/typescript-modified-for-jest.js',
'^@stencil/core/internal/app-data$': '<rootDir>/internal/app-data/index.cjs',
'^@stencil/core/internal/testing$': '<rootDir>/internal/testing/index.js',
},
coverageDirectory: './coverage/',
coverageReporters: ['json', 'lcov', 'text', 'clover'],
@@ -36,7 +37,10 @@ module.exports = {
'<rootDir>/src/testing/**/*.{js,jsx,ts,tsx}',
'<rootDir>/src/utils/**/*.{js,jsx,ts,tsx}',
],
moduleFileExtensions: ['ts', 'tsx', 'js', 'mjs', 'jsx', 'json', 'd.ts'],
modulePathIgnorePatterns: ['/bin', '/www'],
setupFilesAfterEnv: ['<rootDir>/testing/jest-setuptestframework.js'],
testEnvironment: '<rootDir>/testing/jest-environment.js',
testPathIgnorePatterns: [
'<rootDir>/.cache/',
'<rootDir>/.github/',
@@ -57,7 +61,10 @@ module.exports = {
'<rootDir>/testing/',
],
testRegex: '/(src|scripts)/.*\\.spec\\.(ts|tsx|js)$',
// TODO(STENCIL-307): Move away from Jasmine runner for internal Stencil tests, which involves re-working environment
// setup
// TODO(STENCIL-307): Move away from Jasmine runner for internal Stencil tests as a part of the (internal) Jest 28+ upgrade
testRunner: 'jest-jasmine2',
transform: {
'^.+\\.(ts|tsx|jsx|css|mjs)$': '<rootDir>/testing/jest-preprocessor.js',
},
watchPathIgnorePatterns: ['^.+\\.d\\.ts$'],
};
Loading