Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stenciljs/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.5
Choose a base ref
...
head repository: stenciljs/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.0
Choose a head ref
  • 20 commits
  • 31 files changed
  • 4 contributors

Commits on Aug 16, 2023

  1. chore(compiler): jsdoc dependency generation (#4674)

    * chore(compiler): jsdoc dependency generation
    
    this commit adds documentation by the way of jsdoc to the type
    declarations and functions for generating a list of direct/indirect
    dependencies a component has, as well as a list of components that are
    direct/indirect dependent on a component
    
    * review(ap): add note on entries being populated
    rwaskiewicz authored Aug 16, 2023
    Copy the full SHA
    91bb7bc View commit details
  2. fix(runtime): adds a testing check to the forceUpdate method (#4682)

    This commit adds a check for `isTesting` in addition to `isBrowser` so that the forceUpdate logic can run in test environments without needing to change the testing build conditional values. These changes were causing tests to fail in Framework.
    tanner-reits authored Aug 16, 2023
    Copy the full SHA
    7e9544d View commit details
  3. fix(typings): add crossorigin html attr to img (#4686)

    this commit adds the `crossorigin` html attribute for image tages
    (`img`) to stencil's public runtime typings. upon applying this commit,
    projects using stencil should be able to type the following in their
    `render` function and not receive a typing error:
    ```tsx
    render() {
      return <img crossorigin="anonymous"></img>
    }
    ```
    
    Fixes: #4685
    rwaskiewicz authored Aug 16, 2023
    Copy the full SHA
    65d60fb View commit details
  4. feat(compiler): include getAssetPath in generated export statement (#…

    …4683)
    
    * feat(compiler): include `getAssetPath` in generated export statement
    
    * add typedef for `getAssetPath`
    
    * update typedef signature & add typedef to tests
    tanner-reits authored Aug 16, 2023
    Copy the full SHA
    821da79 View commit details
  5. docs(release): notify CS of enterprise fixes (#4648)

    * chore(docs): move release readme to RELEASE.md
    
    * docs(release): add a note to ensure the merge queue has been drained
    
    * add note about pinging issues
    
    * add code freeze call-out
    
    * docs(release): add step to notify CS about customer fixes
    
    * update comment for notifying CS
    
    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    
    ---------
    
    Co-authored-by: Alice Pote <alice.writes.wrongs@gmail.com>
    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    3 people authored Aug 16, 2023
    Copy the full SHA
    838c0b5 View commit details

Commits on Aug 17, 2023

  1. chore(deps): update dependency @rollup/pluginutils to v5.0.3 (#4687)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 17, 2023
    Copy the full SHA
    1eaaa98 View commit details
  2. chore(deps): update dependency @types/node to v20.5.0 (#4691)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 17, 2023
    Copy the full SHA
    b99c3f0 View commit details
  3. chore(deps): update actions/setup-node action to v3.8.0 (#4690)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 17, 2023
    Copy the full SHA
    0d0bc4b View commit details
  4. chore(deps): update dependency autoprefixer to v10.4.15 (#4688)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 17, 2023
    Copy the full SHA
    d090943 View commit details
  5. chore(deps): update dependency ubuntu to v22 (#4671)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 17, 2023
    Copy the full SHA
    5a2ec80 View commit details
  6. chore(deps): update dependency eslint to v8.47.0 (#4692)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 17, 2023
    Copy the full SHA
    2b7ea71 View commit details
  7. chore(deps): update dependency puppeteer to v21.0.3 (#4689)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 17, 2023
    Copy the full SHA
    2629fab View commit details
  8. chore(repo): stub pull request action (#4675)

    this commit creates a new action that will (eventually) go on to create
    pull requests for the stencil team when it is time to release a new
    version of the library. the (eventual) intent is for stencil engineers
    to run this workflow, which will generate a pull request that includes:
    - version bumps in package.json & package-lock.json
    - changelog, notice, and license generation
    
    this commit currently only creates a new branch and commit. the branch
    includes the version string, as well as the run/attempt in github
    actions to tie us back to the run that created it.
    
    at this point, the creation of the pull request is not included. the
    intended library to use
    (https://github.com/peter-evans/create-pull-request) does not work on
    push/pull_request events in GHA without additional permissions. by
    adding this action, we can test it without generating a new token.
    rwaskiewicz authored Aug 17, 2023
    Copy the full SHA
    0e94772 View commit details

Commits on Aug 18, 2023

  1. feat(config): add experimentalSlotFixes config value (#4652)

    This adds a new configuration option inside of the `extras` object
    called `experimentalSlotFixes`. If this is set to `true` then all slot
    fix configuration options will be automatically set to `true` as well.
    
    Furthermore, when new slot fixes are added in the future they'll be
    automatically enabled if you have this flag enabled.
    alicewriteswrongs authored Aug 18, 2023
    Copy the full SHA
    392af26 View commit details

Commits on Aug 21, 2023

  1. chore(deps): update dependency prettier to v3.0.2 (#4705)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 21, 2023
    Copy the full SHA
    bb2b651 View commit details
  2. chore(deps): update actions/setup-node action to v3.8.1 (#4703)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 21, 2023
    Copy the full SHA
    3427c80 View commit details
  3. chore(deps): update dependency puppeteer to v21.1.0 (#4707)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 21, 2023
    Copy the full SHA
    412915b View commit details
  4. chore(deps): update dependency postcss to v8.4.28 (#4704)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 21, 2023
    Copy the full SHA
    5b8cb70 View commit details
  5. chore(deps): update typescript-eslint to v6.4.0 (#4706)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Aug 21, 2023
    Copy the full SHA
    b75bfaa View commit details
  6. 🐟 v4.1.0

    rwaskiewicz committed Aug 21, 2023
    Copy the full SHA
    d44d97e View commit details
Showing with 630 additions and 362 deletions.
  1. +1 −1 .github/workflows/actions/get-core-dependencies/action.yml
  2. +1 −1 .github/workflows/build.yml
  3. +81 −0 .github/workflows/create-production-pr.yml
  4. +1 −1 .github/workflows/lint-and-format.yml
  5. +2 −2 .github/workflows/release-dev.yml
  6. +2 −2 .github/workflows/release-nightly.yml
  7. +3 −3 .github/workflows/tech-debt-burndown.yml
  8. +1 −1 .github/workflows/test-analysis.yml
  9. +2 −2 .github/workflows/test-browserstack.yml
  10. +1 −1 .github/workflows/test-bundlers.yml
  11. +1 −1 .github/workflows/test-component-starter.yml
  12. +1 −1 .github/workflows/test-e2e.yml
  13. +1 −1 .github/workflows/test-unit.yml
  14. +16 −0 CHANGELOG.md
  15. +3 −0 RELEASE.md
  16. +326 −324 package-lock.json
  17. +4 −4 package.json
  18. +25 −0 src/compiler/config/test/validate-config.spec.ts
  19. +12 −0 src/compiler/config/validate-config.ts
  20. +75 −4 src/compiler/entries/resolve-component-dependencies.ts
  21. +6 −0 src/compiler/output-targets/dist-custom-elements/custom-elements-types.ts
  22. +1 −1 src/compiler/output-targets/dist-custom-elements/index.ts
  23. +24 −0 src/compiler/output-targets/test/custom-elements-types.spec.ts
  24. +6 −6 src/compiler/output-targets/test/output-targets-dist-custom-elements.spec.ts
  25. +19 −0 src/declarations/stencil-private.ts
  26. +7 −0 src/declarations/stencil-public-compiler.ts
  27. +2 −0 src/declarations/stencil-public-runtime.ts
  28. +2 −2 src/runtime/test/globals.spec.tsx
  29. +1 −1 src/runtime/update-component.ts
  30. +2 −2 src/testing/platform/testing-build.ts
  31. +1 −1 test/end-to-end/src/build-data/build-data.spec.ts
2 changes: 1 addition & 1 deletion .github/workflows/actions/get-core-dependencies/action.yml
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ runs:
# jobs that need a different version of the Node runtime should explicitly
# set their node version after running this step
- name: Use Node Version from Volta
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version-file: './package.json'
cache: 'npm'
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ on:
jobs:
build_core:
name: Core
runs-on: 'ubuntu-20.04'
runs-on: 'ubuntu-22.04'
steps:
- name: Checkout Code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
81 changes: 81 additions & 0 deletions .github/workflows/create-production-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
name: 'Stencil Release PR Creation'
on:
workflow_dispatch:
inputs:
version:
required: true
type: choice
description: Which version should be published?
options:
- prerelease
- prepatch
- preminor
- premajor
- patch
- minor
- major

jobs:
create-stencil-release-pull-request:
name: Generate Stencil Release PR
runs-on: ubuntu-latest
steps:
# Log the input from GitHub Actions for easy traceability
- name: Log GitHub Input
run: |
echo "Version: ${{ inputs.version }}"
shell: bash

- name: Checkout Code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
with:
# A depth of 0 gets the entire git history.
# We need git history to generate the changelog; however, we don't know how deep to go.
# Since publishing is a one-off activity, just get everything.
fetch-depth: 0

- name: Get Core Dependencies
uses: ./.github/workflows/actions/get-core-dependencies

- name: Run Publish Preparation Script
run: npm run release.ci.prepare -- --version ${{ inputs.version }} --any-branch
shell: bash

- name: Log Generated Changes
run: git --no-pager diff
shell: bash

- name: Generate Version String and Branch Name
id: name_gen
run: |
VERSION_STR=$(jq '.version' package.json | sed s/\"//g)
echo "VERSION_STR=$VERSION_STR" >> "$GITHUB_OUTPUT"
echo "BRANCH_NAME=release/$VERSION_STR-run-${{ github.run_number }}-${{ github.run_attempt }}" >> "$GITHUB_OUTPUT"
shell: bash

- name: Print Version String and Branch Name
run: |
echo Version: ${{ steps.name_gen.outputs.VERSION_STR }}
echo Branch Name: ${{ steps.name_gen.outputs.BRANCH_NAME }}
shell: bash

- name: Create Git Branch
# Note: We'll let GitHub clean up the branch for us (this is configured in the repo settings on GitHub)
run: git checkout -b ${{ steps.name_gen.outputs.BRANCH_NAME }}

# Commit the CHANGELOG.md, NOTICE.md, LICENSE.md, package.json, etc.
- name: Commit Release Preparations
run: |
git config user.name "Stencil Release Bot (on behalf of ${{ github.actor }})"
git config user.email "stencil-release-bot@ionic.io"
git add .
git commit -m "v${{ steps.name_gen.outputs.VERSION_STR }}"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
shell: bash

- name: Push Branch to GitHub
run: |
git push --set-upstream origin ${{ steps.name_gen.outputs.BRANCH_NAME }}
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/lint-and-format.yml
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ on:
jobs:
format:
name: Check
runs-on: 'ubuntu-20.04'
runs-on: 'ubuntu-22.04'
steps:
- name: Checkout Code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
4 changes: 2 additions & 2 deletions .github/workflows/release-dev.yml
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ jobs:
get-dev-version:
name: Get Dev Build Version
needs: [build_core]
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
outputs:
dev-version: ${{ steps.get-dev-version.outputs.DEV_VERSION }}
steps:
@@ -50,7 +50,7 @@ jobs:
release-stencil-dev-build:
name: Publish Dev Build
needs: [get-dev-version, build_core]
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
permissions:
id-token: write
steps:
4 changes: 2 additions & 2 deletions .github/workflows/release-nightly.yml
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ jobs:
get-nightly-version:
name: Get Nightly Build Version
needs: [build_core]
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
outputs:
nightly-version: ${{ steps.get-nightly-version.outputs.NIGHTLY_VERSION }}
steps:
@@ -55,7 +55,7 @@ jobs:
release-stencil-nightly-build:
name: Publish Nightly Build
needs: [get-nightly-version, build_core]
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
permissions:
id-token: write
steps:
6 changes: 3 additions & 3 deletions .github/workflows/tech-debt-burndown.yml
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ jobs:
matrix:
branch: ['main', 'pr']
name: 'Get strictNullChecks errors on ${{ matrix.branch }}'
runs-on: 'ubuntu-20.04'
runs-on: 'ubuntu-22.04'
steps:
- name: Checkout main
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
@@ -55,7 +55,7 @@ jobs:
matrix:
branch: ['main', 'pr']
name: Find unused variables on ${{ matrix.branch }}
runs-on: 'ubuntu-20.04'
runs-on: 'ubuntu-22.04'
steps:
- name: Checkout main
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
@@ -87,7 +87,7 @@ jobs:
format_report:
needs: ['strict_null_check', 'unused_exports_check']
name: Download error files and report
runs-on: 'ubuntu-20.04'
runs-on: 'ubuntu-22.04'
steps:
- name: Checkout current branch
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
2 changes: 1 addition & 1 deletion .github/workflows/test-analysis.yml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ jobs:
uses: ./.github/workflows/actions/get-core-dependencies

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: ${{ matrix.node }}
cache: 'npm'
4 changes: 2 additions & 2 deletions .github/workflows/test-browserstack.yml
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ jobs:

run_browserstack:
name: Run Browserstack
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
needs: [build_core]

# The concurrency field allows us to block multiple invocations of this job across multiple workflow runs.
@@ -59,7 +59,7 @@ jobs:
persist-credentials: false

- name: Use Node Version from Volta (Karma)
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
# pull the version to use from the volta key in package.json
node-version-file: './test/karma/package.json'
2 changes: 1 addition & 1 deletion .github/workflows/test-bundlers.yml
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ on:
jobs:
bundler_tests:
name: Verify Bundlers
runs-on: 'ubuntu-20.04'
runs-on: 'ubuntu-22.04'
steps:
- name: Checkout Code
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
2 changes: 1 addition & 1 deletion .github/workflows/test-component-starter.yml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ jobs:
uses: ./.github/workflows/actions/get-core-dependencies

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: ${{ matrix.node }}
cache: 'npm'
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ jobs:
uses: ./.github/workflows/actions/get-core-dependencies

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: ${{ matrix.node }}
cache: 'npm'
2 changes: 1 addition & 1 deletion .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ jobs:
uses: ./.github/workflows/actions/get-core-dependencies

- name: Use Node ${{ matrix.node }}
uses: actions/setup-node@e33196f7422957bea03ed53f6fbb155025ffc7b8 # v3.7.0
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version: ${{ matrix.node }}
cache: 'npm'
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
# 🐟 [4.1.0](https://github.com/ionic-team/stencil/compare/v4.0.5...v4.1.0) (2023-08-21)


### Bug Fixes

* **runtime:** adds a testing check to the forceUpdate method ([#4682](https://github.com/ionic-team/stencil/issues/4682)) ([7e9544d](https://github.com/ionic-team/stencil/commit/7e9544d4c9c586d9bdd969a0ae9a6a0bb7681d90))
* **typings:** add crossorigin html attr to img ([#4686](https://github.com/ionic-team/stencil/issues/4686)) ([65d60fb](https://github.com/ionic-team/stencil/commit/65d60fbef16efd35f5680787c0e72a4b4b410a2b)), closes [#4685](https://github.com/ionic-team/stencil/issues/4685)


### Features

* **compiler:** include `getAssetPath` in generated export statement ([#4683](https://github.com/ionic-team/stencil/issues/4683)) ([821da79](https://github.com/ionic-team/stencil/commit/821da79c3b4e32f8580257f45bea4733577c08f3))
* **config:** add experimentalSlotFixes config value ([#4652](https://github.com/ionic-team/stencil/issues/4652)) ([392af26](https://github.com/ionic-team/stencil/commit/392af26f08a8c2b08b90d367a30e737f6612b979))



## 🚣 [4.0.5](https://github.com/ionic-team/stencil/compare/v4.0.4...v4.0.5) (2023-08-14)


3 changes: 3 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
@@ -71,4 +71,7 @@ manual release was performed.
```
1. Let folks in Ionic know about the release in the #whathappened Slack channel
with a link to the changelog.
1. Let the CS team know by 'at-ing' them about any enterprise reported issues or feature requests that were included in the release in a thread on your #whathappened post. Jira
tickets related to enterprise requests should be marked with the "jira_escalated" label and/or the "Enterprise Support"
or "Enterprise Feature Requests" epic.
1. End the code freeze in the Stencil team Slack channel.
Loading