Comparing changes

Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

now that stencil releases are largely automated, release tasks that were skipped during manual releases can be removed. this commit removes all tasks that were skipped with `isCI` is was `true` (as it's always `true` these days). additional conditionals that use logical-AND with `isCI` have been updated, as that part of the conditional is now always `true`. remove the `--otp` flag, as it is only used for manual releases as a result of these removals, the `--any-branch` flag can be safely removed from our release pipeline, as its no longer used.

This removes the dependence of the esbuild-based build on the existing Rollup-based build. Previously we needed to run the Rollup-based build first so that certain files which could not yet be built with Esbuild would be present on disk, but since we can now build everything with Esbuild we don't need to take this step anymore. We do, however, continue to need to run the TypeScript compiler in order to generate up-to-date typedef files. Part of STENCIL-1016

After we removed the old release scripts recently this option is no longer used anywhere, so we can delete it.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

the url that pulls down chrome images seems to be intermittedly failing in github actions. when we go to install dependencies (`npm ci`), we're greeted with an error: ``` npm ERR! code 1 npm ERR! path /home/runner/work/stencil/stencil/node_modules/puppeteer npm ERR! command failed npm ERR! command sh -c node install.mjs npm ERR! Error: ERROR: Failed to set up chrome-headless-shell v121.0.6167.85! Set "PUPPETEER_SKIP_DOWNLOAD" env variable to skip download. ``` this appears to be a result of an intermittent failure (if it's intermittent it to-be-determined). reports online suggest bumping to puppeteer v22, which we cannot do at this moment due to it dropping support for node 16. instead, set the base url environment variable to tell puppeteer where to pull chrome from

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

When we added a script for building the modules in `internal/` with Esbuild in #5276 we needed to make a change to the function that Stencil uses at runtime to lazy-load components (in `src/client/client-load-module.ts`). Prior to #5276 we had a dynamic import statement which looked like so: ```ts import( `./${bundleId}.entry.js${BUILD.hotModuleReplacement && hmrVersionId ? '?s-hmr=' + hmrVersionId : ''}` ) ``` This constructs a filepath to the module for a given Stencil component, accounting for HMR versioning, and then imports the module. All well and good, but unfortunately this dynamic import does not play well with Esbuild. As described [here](https://esbuild.github.io/api/#non-analyzable-imports) when Esbuild is in 'bundle' mode and it encounters an `import()` _and_ the imported path or identifier looks "analyzable" it will attempt to resolve the corresponding file and incorporate it into the bundle. This is not always what you want! In particular, in our situation the leading `"./"` in the template literal we had in `client-load-module.ts` caused Esbuild to consider the `import()` an "analyzable" import and it then tried to resolve and bundle the import instead of just leaving the dynamic import in the code (as Rollup does in this case). This created an issue because at _compile time_ (i.e. when Stencil itself is built) this import does not resolve to anything, so Esbuild would essentially transform that line into an empty import. This caused runtime issues because the side-effect of the dynamic import was no longer happening, so the modules containing Stencil component classes and so on were not longer being loaded in. To get this working for #5276 we pulled out the `"./"` string as a separate variable, changing the template literal so it looks something like this: ```ts const MODULE_IMPORT_PREFIX = './'; import( `${MODULE_IMPORT_PREFIX}${bundleId}.entry.js${BUILD.hotModuleReplacement && hmrVersionId ? '?s-hmr=' + hmrVersionId : ''}` ) ``` This causes Esbuild to conclude that the import is "non-analyzable", which addresses the issue and causes both Rollup and Esbuild to emit equivalent code for this snippet, where both retain the dynamic import, allowing for the runtime module resolution that we want here. _However_, this broke the ability to use Stencil with Vite, which will complain about non-analyzable imports if it sees a dynamic import which does _not_ begin with `"./"`. See #5389 for details. So essentially we have a situation where the behavior of Rollup, Esbuild, and Vite is incompatible. The solution is to figure out a way for both the Esbuild and Rollup builds to emit code in this case which retains the dynamic import _and_ retains the leading `"./"` in the template literal. This is accomplished by retaining the `${MODULE_IMPORT_PREFIX}` in the template literal, so that Esbuild does not attempt to analyze and bundle the import, and adding plugins to both the Rollup and Esbuild bundles to transform the emitted code before it is written to disk. fixes #5389 STENCIL-1181

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* v4.12.4 * add 'closes' issue to changelog --------- Co-authored-by: rwaskiewicz <1930213+rwaskiewicz@users.noreply.github.com> Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>

-Original file line number
+Diff line change
@@ @@ -48,7 +48,7 @@ jobs: @@
           # TODO(STENCIL-927): Backport changes to the v3 branch
           - name: Run Publish Preparation Script
-            run: npm run release.ci.prepare -- --version ${{ inputs.version }} --any-branch
+            run: npm run release.ci.prepare -- --version ${{ inputs.version }}
             shell: bash
           - name: Log Generated Changes

-Original file line number
+Diff line change
@@ @@ -63,5 +63,5 @@ jobs: @@
           - name: Run Publish Scripts
             # pass the generated version number instead of the input, since we've already incremented it in the prerelease
             # step
-            run: npm run release.ci -- --any-branch --tag ${{ inputs.tag }}
+            run: npm run release.ci -- --tag ${{ inputs.tag }}
             shell: bash

-Original file line number
+Diff line change
@@ @@ -4,3 +4,5 @@ @@
     # If this value is changed, please ensure that it works both locally and in a continuous integration environment in
     # a repeatable manner (i.e. it can run many times, one after the other, without failing due to out-of-memory errors).
     node_options=--max-old-space-size=4096
+    # TODO(STENCIL-1141): remove `PUPPETEER_DOWNLOAD_BASE_URL` once support for Node v16 is dropped
+    PUPPETEER_DOWNLOAD_BASE_URL=https://storage.googleapis.com/chrome-for-testing-public

-Original file line number
+Diff line change
@@ -1,3 +1,12 @@
+    ## 🐮 [4.12.4](https://github.com/ionic-team/stencil/compare/v4.12.3...v4.12.4) (2024-02-26)
+    ### Bug Fixes
+    * **build:** address issue with dynamic import and vite ([#5399](https://github.com/ionic-team/stencil/issues/5399)) ([8ebacae](https://github.com/ionic-team/stencil/commit/8ebacae1106704293a2b1720b44eb83209175f96)), closes [#5389](https://github.com/ionic-team/stencil/issues/5389)
     ## 🐍 [4.12.3](https://github.com/ionic-team/stencil/compare/v4.12.2...v4.12.3) (2024-02-20)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comparing changes

Open a pull request

Commits on Feb 20, 2024

Commits on Feb 21, 2024

Commits on Feb 22, 2024

Commits on Feb 23, 2024

Commits on Feb 26, 2024

There are no files selected for viewing