Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The namedExports option from "@rollup/plugin-commonjs" is deprecated #2523

Closed
elpupi opened this issue Jun 19, 2020 · 1 comment · Fixed by #4532
Closed

The namedExports option from "@rollup/plugin-commonjs" is deprecated #2523

elpupi opened this issue Jun 19, 2020 · 1 comment · Fixed by #4532
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@elpupi
Copy link

elpupi commented Jun 19, 2020

Stencil version:

 @stencil/core@1.14.0

I'm submitting a:

[x] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

stencil.config.ts allows to specify commonjs plugin option. Firstly, only namedExports is allowed in commonjs?: BundlingConfig. Secondly, the namedExportsoption is deprecated in@rollup/plugin-commonjs`.

Running stencil build, the following message is shown:

[ WARN  ]  Bundling Warning PLUGIN_WARNING
           The namedExports option from "@rollup/plugin-commonjs" is deprecated. Named exports are now handled

Looking at the @rollup/plugin-commonjs code commonjs/src/index.js, the option is ignored. So it is really misleading and error prone when updating the version up as it was working before.

Expected behavior:

Remove namedExports from BundlingConfig and show an error message. And if possible, allow the other commonjs options.
@ionitron-bot ionitron-bot bot added the triage label Jun 19, 2020
@rwaskiewicz rwaskiewicz added the Bug: Validated This PR or Issue is verified to be a bug within Stencil label Jun 16, 2023
@ionitron-bot ionitron-bot bot removed the triage label Jun 16, 2023
rwaskiewicz added a commit that referenced this issue Jun 30, 2023
@rwaskiewicz
fix(rollup-config): deprecate BundlingConfig#namedExports
6c12ce9 
this commit deprecates the `namedExports` field on the `BundlingConfig`
interface. `@rollup/plugin-commonjs` no longer honors this field as of
rollup/plugins@5d2dcf4.

Fixes: #2523

STENCIL-867
@rwaskiewicz rwaskiewicz mentioned this issue Jun 30, 2023
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 13, 2023
@rwaskiewicz
fix(rollup-config): deprecate BundlingConfig#namedExports (#4532)
a353769 
this commit deprecates the `namedExports` field on the `BundlingConfig`
interface. `@rollup/plugin-commonjs` no longer honors this field as of
rollup/plugins@5d2dcf4.

Fixes: #2523

STENCIL-867
@rwaskiewicz
Copy link
Member

The fix for this issue has been released as a part of today's Stencil v4.0.2 release. We've officially deprecated the field and marked it as such in our documentation site. To avoid a (small) breaking change, we will not remove this field until Stencil v5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rollup-config): deprecate BundlingConfig#namedExports ionic-team/stencil
2 participants
@rwaskiewicz @elpupi