Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taskQueue: "immediate" rendering nothing #2630

Merged
merged 1 commit into from Aug 12, 2020

Conversation

maxjustus
Copy link
Contributor

With taskQueue: "async" and "congestedAsync" scheduleUpdate calls writeTask, passing it the dispatch callback. writeTask calls the passed in dispatch callback in process.nextTick

Before this change, when the taskQueue: was set to immediate, the dispatch callback was never called. Resulting in no components rendering in the DOM.

Fixes #2491

With taskQueue: "async" and "congestedAsync" `scheduleUpdate` calls
`writeTask`, passing it the `dispatch` callback. `writeTask` calls the
passed in dispatch callback in `process.nextTick()`

Before this change, when the taskQueue: was set to `immediate`, the
dispatch callback was never called. Resulting in no components rendering
in the DOM.
@adamdbradley adamdbradley merged commit 62ea511 into ionic-team:master Aug 12, 2020
@adamdbradley
Copy link
Contributor

thanks for the fix!

@maxjustus maxjustus deleted the fix-immediate-task-queue branch September 16, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stencil 1.14.0 doesn't render anything with taskQueue: 'immediate'
2 participants