bug: tsconfig include array triggers warning when path has leading ./

[cam-narzt]

Prerequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Stencil Version

4.0.4

Current Behavior

if your tsconfig looks like this:

"include": [
        "./app/javascript"
    ],

you will get the very confusing warning:

[ WARN  ]  tsconfig.json "include" required
           In order for TypeScript to improve watch performance, it's recommended the "tsconfig.json" file should have
           the "include" property, with at least the app's "app/javascript" directory listed. For example: "include":
           ["app/javascript"]

Expected Behavior

paths that are equivalent shouldn't raise this warning

System Info

npx stencil info doesn't work on my system and isn't relevant in this case.

Steps to Reproduce

clone linked repo
checkout tsconfig_bug branch
run npm i
run npm run build

Code Reproduction URL

https://github.com/cam-narzt/stencilbug/tree/tsconfig_bug

Additional Information

No response

[rwaskiewicz]

Hey @cam-narzt 👋

Thanks for bug report + reproduction case! I took a look at it this morning, and wasn't able to reproduce the error exactly on my end. Following the steps to repro, I:

• Cloned the repo
• Checked out tsconfig_bug (where the HEAD is c417fd76254031f390d0b564c18af36d1dce350e)
• Ran npm ci to get the same dependencies
• Ran npm run build

I do get an error message, but it looks like it's properly listing the 'src' directory in the error message instead of 'app/javascript':

➜  stencilbug git:(tsconfig_bug) npm run build

> demo-error@0.0.1 build
> stencil build --docs

[56:01.5]  @stencil/core
[56:01.7]  v4.0.4 🍧

[ WARN  ]  tsconfig.json "include" required
           In order for TypeScript to improve watch performance, it's recommended the "tsconfig.json" file should have
           the "include" property, with at least the app's "src" directory listed. For example: "include": ["src"]

Does it look like I'm missing anything here?

[cam-narzt]

Ah I forgot to commit one file while I was making the reproduction repo, the head is 72c19dcc now.

the stencil config srcDir and tsconfig include must match exactly, being equivalent isn't enough, which is what makes the error confusing.

[rwaskiewicz]

Ah, gotcha! Makes sense - I can reproduce this now. Thanks!

[rwaskiewicz]

@cam-narzt I've created #4676 to fix this - I've created a dev build of Stencil that includes the fix atop of v4.0.4. If you get a moment, can you try installing it and let me know how it goes?

npm i @stencil/core@v4.0.4-dev.1691704809.9fb61d7

[cam-narzt]

That fixed the issue on my end, lgtm.

[rwaskiewicz]

The fix for this issue went out with today's v4.0.5 release. As such, I'm going to close it out. Should it appear again, please feel free to open a new issue. Thanks!