Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The img tag doesn't support the crossOrigin attribute #4685

Closed
3 tasks done
wabi-habi opened this issue Aug 16, 2023 · 6 comments
Closed
3 tasks done

bug: The img tag doesn't support the crossOrigin attribute #4685

wabi-habi opened this issue Aug 16, 2023 · 6 comments
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@wabi-habi
Copy link

Prerequisites

Stencil Version

^4.0.0

Current Behavior

iShot_2023-08-16_10 21 34

Expected Behavior

Both video and audio are supported, I would expect img to support the crossOrigin attribute as well!

System Info

No response

Steps to Reproduce

iShot_2023-08-16_10 21 34

Code Reproduction URL

No Link

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Aug 16, 2023
@rwaskiewicz rwaskiewicz added the Bug: Validated This PR or Issue is verified to be a bug within Stencil label Aug 16, 2023
@ionitron-bot ionitron-bot bot removed the triage label Aug 16, 2023
@rwaskiewicz
Copy link
Member

Thanks!

@wabi-habi
Copy link
Author

Thanks!

It will be updated in the next version yes? How do I temporarily fix this error in the current version?

rwaskiewicz added a commit that referenced this issue Aug 16, 2023
this commit adds the `crossorigin` html attribute for image tages
(`img`) to stencil's public runtime typings. upon applying this commit,
projects using stencil should be able to type the following in their
`render` function and not receive a typing error:
```tsx
render() {
  return <img crossorigin="anonymous"></img>
}
```

Fixes: #4685
@rwaskiewicz
Copy link
Member

#4686 has been created to fix this issue. In the interim, you'll need to us @ts-ignore pragmas in order to suppress the error

@wabi-habi
Copy link
Author

#4686 has been created to fix this issue. In the interim, you'll need to us @ts-ignore pragmas in order to suppress the error

Okay, thanks.

github-merge-queue bot pushed a commit that referenced this issue Aug 16, 2023
this commit adds the `crossorigin` html attribute for image tages
(`img`) to stencil's public runtime typings. upon applying this commit,
projects using stencil should be able to type the following in their
`render` function and not receive a typing error:
```tsx
render() {
  return <img crossorigin="anonymous"></img>
}
```

Fixes: #4685
@rwaskiewicz
Copy link
Member

The fix for this issue has been released as a part of today's Stencil v4.1.0 release

@wabi-habi
Copy link
Author

The fix for this issue has been released as a part of today's Stencil v4.1.0 release

It's really great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

No branches or pull requests

2 participants