Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SCSS doesn't rebuild when path is outside stencil directory #5599

Open
3 tasks done
James-Wilkinson-git opened this issue Mar 28, 2024 · 9 comments
Open
3 tasks done
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@James-Wilkinson-git
Copy link

Prerequisites

Stencil Version

4.13

Current Behavior

When you make a change to an SCSS file that lives outside of the stencil directory the changes are not picked up and re-rendered. This is an issue when using stencil in a mono-repo environment with shared styles.

Expected Behavior

Watcher should listen for changes and recompile scss when the files provided are changed.

System Info

No response

Steps to Reproduce

Edit the scss and see it doesn't update from red to blue for example.
https://github.com/James-Wilkinson-git/stencil-bug

Code Reproduction URL

https://github.com/James-Wilkinson-git/stencil-bug

Additional Information

Relates too #2635

@ionitron-bot ionitron-bot bot added the triage label Mar 28, 2024
@christian-bromann christian-bromann self-assigned this Apr 1, 2024
@christian-bromann
Copy link
Member

@James-Wilkinson-git thanks for raising the issue.

I am not really able to reproduce this. I checked out the code, installed the dependencies and ran npm start. I am able to make changes to the .scss file, see:

repro

Anything I am doing wrong here?

@James-Wilkinson-git
Copy link
Author

I blew away node_modules and package-lock did a fresh npm install and still the same issue it doesn't run. Also using VSCode.

My co-worker on a mac also sees the same issue, what could be causing it?

@christian-bromann
Copy link
Member

Can you provide a step by step explanation how this can be reproduced on your machine using the reproducible example?

@James-Wilkinson-git
Copy link
Author

I did… fresh install the repo and I have the problem. But you did It and dont. So something has to be up with the watcher source code compiling on install maybe? Node versions? Windows versions? I don’t know how that stuff works to help troubleshoot better

@christian-bromann
Copy link
Member

Windows versions?

Are you on Windows?

@James-Wilkinson-git
Copy link
Author

npm 8.19.4
node 20.10.0
Windows 10 Enterprise x64

@christian-bromann
Copy link
Member

Thanks for this information. We were able to validate this defect on Windows. We will ingest this into our backlog and will prioritize it accordingly.

@christian-bromann christian-bromann added Bug: Validated This PR or Issue is verified to be a bug within Stencil and removed triage labels Apr 2, 2024
@christian-bromann christian-bromann removed their assignment Apr 2, 2024
@tfrijsewijk
Copy link

Oh that's great news!

@James-Wilkinson-git
Copy link
Author

James-Wilkinson-git commented Apr 18, 2024

This may be related, I might need to use powershell instead of git-bash inside vscode to get it to work until windows fixes microsoft/WSL#4739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

No branches or pull requests

3 participants