Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove mutable props concept #5644

Open
3 tasks done
maxpatiiuk opened this issue Apr 9, 2024 · 0 comments
Open
3 tasks done

feat: Remove mutable props concept #5644

maxpatiiuk opened this issue Apr 9, 2024 · 0 comments
Assignees
Labels

Comments

@maxpatiiuk
Copy link

maxpatiiuk commented Apr 9, 2024

Prerequisites

Describe the Feature Request

As it stands now, prop being mutable doesn't do anything other than suppress a warning about modifying a prop.
Is there a reason that warning was put in?
This seems like a needless behavior that only worsens DX, and makes testing components harder.

Describe the Use Case

  • Do two-way sync of props with external store
  • Modify props in tests
  • Reset prop values on hot-module-replacement

Describe Preferred Solution

Remove the useless warning

Describe Alternatives

OR deprecate the concept of non-mutable props
OR add a stencil config option to make all props mutable

Related Code

No response

Additional Information

Related to #3490

@ionitron-bot ionitron-bot bot added the triage label Apr 9, 2024
@rwaskiewicz rwaskiewicz self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants