Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: child input element is receiving un-wanted props #5707

Open
3 tasks done
mad-raccoon opened this issue Apr 26, 2024 · 10 comments
Open
3 tasks done

bug: child input element is receiving un-wanted props #5707

mad-raccoon opened this issue Apr 26, 2024 · 10 comments
Labels
ionitron: needs reproduction This PR or Issue does not have a reproduction case URL

Comments

@mad-raccoon
Copy link

mad-raccoon commented Apr 26, 2024

Prerequisites

Stencil Version

4.17.1

Current Behavior

Whenever the user interacts with an input element inside the component, that input element inherits un-wanted props from the stencil component element.

I am using the component like this:

<my-component first="Stencil" last="'Don't call me a framework' JS"></my-component>

That is defined like this:

image

Problem

Whenever I interact with the input, the props first="Stencil" last="'Don't call me a framework' JS" are getting passed to the input element:

image

Here is a sandbox with the issue: Sandbox

Expected Behavior

Not pass the properties to the input element

System Info

No response

Steps to Reproduce

Click on the input element.

Code Reproduction URL

https://codesandbox.io/p/devbox/crimson-breeze-kd5g4r?layout=%257B%2522sidebarPanel%2522%253A%2522EXPLORER%2522%252C%2522rootPanelGroup%2522%253A%257B%2522direction%2522%253A%2522horizontal%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522id%2522%253A%2522ROOT_LAYOUT%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522UNKNOWN%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522clvgkimok00073b6q5znuvqxq%2522%252C%2522sizes%2522%253A%255B70%252C30%255D%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522EDITOR%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522EDITOR%2522%252C%2522id%2522%253A%2522clvgkimok00023b6qijh57yjk%2522%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522direction%2522%253A%2522horizontal%2522%252C%2522id%2522%253A%2522SHELLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522SHELLS%2522%252C%2522id%2522%253A%2522clvgkimok00043b6qlai19bph%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%257D%252C%257B%2522type%2522%253A%2522PANEL_GROUP%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522direction%2522%253A%2522vertical%2522%252C%2522id%2522%253A%2522DEVTOOLS%2522%252C%2522panels%2522%253A%255B%257B%2522type%2522%253A%2522PANEL%2522%252C%2522contentType%2522%253A%2522DEVTOOLS%2522%252C%2522id%2522%253A%2522clvgkimok00063b6q2q3c8qal%2522%257D%255D%252C%2522sizes%2522%253A%255B100%255D%257D%255D%252C%2522sizes%2522%253A%255B90%252C10%255D%257D%252C%2522tabbedPanels%2522%253A%257B%2522clvgkimok00023b6qijh57yjk%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clvgkimok00013b6qsidebo4f%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fsrc%252Findex.ts%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522id%2522%253A%2522clvgkkeu0004p3b6q3g1x4td5%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522initialSelections%2522%253A%255B%257B%2522startLineNumber%2522%253A32%252C%2522startColumn%2522%253A52%252C%2522endLineNumber%2522%253A32%252C%2522endColumn%2522%253A52%257D%255D%252C%2522filepath%2522%253A%2522%252Fsrc%252Fcomponents%252Fmy-component%252Fmy-component.tsx%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%252C%257B%2522id%2522%253A%2522clvgl748i00023b6j2dan8n71%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522FILE%2522%252C%2522filepath%2522%253A%2522%252Fpackage.json%2522%252C%2522state%2522%253A%2522IDLE%2522%257D%255D%252C%2522id%2522%253A%2522clvgkimok00023b6qijh57yjk%2522%252C%2522activeTabId%2522%253A%2522clvgl748i00023b6j2dan8n71%2522%257D%252C%2522clvgkimok00063b6q2q3c8qal%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clvgkimok00053b6qdbz3vikl%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TASK_PORT%2522%252C%2522taskId%2522%253A%2522dev%2522%252C%2522port%2522%253A3333%252C%2522path%2522%253A%2522%252F%2522%257D%255D%252C%2522id%2522%253A%2522clvgkimok00063b6q2q3c8qal%2522%252C%2522activeTabId%2522%253A%2522clvgkimok00053b6qdbz3vikl%2522%257D%252C%2522clvgkimok00043b6qlai19bph%2522%253A%257B%2522tabs%2522%253A%255B%257B%2522id%2522%253A%2522clvgkimok00033b6q5qm0s7xt%2522%252C%2522mode%2522%253A%2522permanent%2522%252C%2522type%2522%253A%2522TASK_LOG%2522%252C%2522taskId%2522%253A%2522dev%2522%257D%255D%252C%2522id%2522%253A%2522clvgkimok00043b6qlai19bph%2522%252C%2522activeTabId%2522%253A%2522clvgkimok00033b6q5qm0s7xt%2522%257D%257D%252C%2522showDevtools%2522%253Atrue%252C%2522showShells%2522%253Atrue%252C%2522showSidebar%2522%253Atrue%252C%2522sidebarPanelSize%2522%253A28.908701854493586%257D

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Apr 26, 2024
@mad-raccoon mad-raccoon changed the title bug: child input element is receiving un-wanted bug: child input element is receiving un-wanted props Apr 26, 2024
@tanner-reits
Copy link
Member

@mad-raccoon I wasn't able to reproduce what you're describing either locally or in the provided sandbox. Are there specific steps that cause this behavior?

@tanner-reits tanner-reits added Awaiting Reply This PR or Issue needs a reply from the original reporter. and removed triage labels Apr 26, 2024
@mad-raccoon
Copy link
Author

@tanner-reits I updated the sandbox.

Here is a screen recording of the behavior I described. Notice that at the beginning the input element has no props, and after I click on it, it gets the properties first and last

smaller.mov

@ionitron-bot ionitron-bot bot removed the Awaiting Reply This PR or Issue needs a reply from the original reporter. label Apr 28, 2024
@mad-raccoon
Copy link
Author

@tanner-reits after some investigation, i discovered that this only happens with google chrome

@tanner-reits
Copy link
Member

@mad-raccoon Yeah I'm not able to get that to happen on my end. Looks like you have chrome update in the video you sent, does it still happen if you update to the latest version?

@tanner-reits tanner-reits added Awaiting Reply This PR or Issue needs a reply from the original reporter. and removed triage labels May 2, 2024
@mad-raccoon
Copy link
Author

@tanner-reits I have it updated. I am using this one:

Chrome is up-to-date
Version 124.0.6367.119 (Official Build) (arm64)

@ionitron-bot ionitron-bot bot removed the Awaiting Reply This PR or Issue needs a reply from the original reporter. label May 6, 2024
@tanner-reits
Copy link
Member

@mad-raccoon Both myself and @rwaskiewicz are unable to reproduce this issue. Do you have any browser extensions installed that might be playing a role? I'm on the same Chrome version you reported, so, it seems this is an issue specific to your machine.

@tanner-reits tanner-reits added the Awaiting Reply This PR or Issue needs a reply from the original reporter. label May 6, 2024
@mad-raccoon
Copy link
Author

@tanner-reits how are you trying to replicate this issue? Local or via the playground I shared ?

Also, are you using Mac or Windows ? I am on Mac

@ionitron-bot ionitron-bot bot removed the Awaiting Reply This PR or Issue needs a reply from the original reporter. label May 6, 2024
@tanner-reits
Copy link
Member

@mad-raccoon I'm on a mac. I've tried to reproduce both locally and in the playground.

@christian-bromann
Copy link
Member

@mad-raccoon maybe one way to create a reproducible example is to adjust Stencils e2e tests and make them fail based on your observations. Please raise a PR for this and we can take a look.

@christian-bromann christian-bromann added the ionitron: needs reproduction This PR or Issue does not have a reproduction case URL label May 7, 2024
Copy link

ionitron-bot bot commented May 7, 2024

Thanks for the issue! This issue has been labeled as needs reproduction. This label is added to issues that need a code reproduction.

Please reproduce this issue in an Stencil starter component library and provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed.

If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue.

For a guide on how to create a good reproduction, see our Contributing Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ionitron: needs reproduction This PR or Issue does not have a reproduction case URL
Projects
None yet
Development

No branches or pull requests

4 participants