Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cannot read property 'type' of null": 0.7.16 -> 0.7.17+ #733

Closed
bitflower opened this issue Apr 15, 2018 · 8 comments
Closed

"Cannot read property 'type' of null": 0.7.16 -> 0.7.17+ #733

bitflower opened this issue Apr 15, 2018 · 8 comments
Assignees

Comments

@bitflower
Copy link
Contributor

bitflower commented Apr 15, 2018

Stencil version:

 @stencil/core@0.7.17+>

I'm submitting a:

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

Current behavior:
Doesn't compile anymore. Did without problems prior to 0.7.17+.
No other code changes.

The terminal out:

{ TypeError: Cannot read property 'type' of null
    at error (/Users/matthias/Documents/Projekte/bitflower/Case OS/Prototype/v0.2/caseos-ui/node_modules/rollup/dist/rollup.js:168:15)
    at Object.error (/Users/matthias/Documents/Projekte/bitflower/Case OS/Prototype/v0.2/caseos-ui/node_modules/rollup/dist/rollup.js:19382:21)
    at /Users/matthias/Documents/Projekte/bitflower/Case OS/Prototype/v0.2/caseos-ui/node_modules/rollup/dist/rollup.js:19391:29
    at <anonymous>
  code: 'PLUGIN_ERROR',
  plugin: undefined,
  id: '/Users/matthias/Documents/Projekte/bitflower/Case OS/Prototype/v0.2/caseos-ui/node_modules/rollup-plugin-node-builtins/src/es6/http-lib/to-arraybuffer.js' }
[27:13.3]  module map finished in 2.57 s
[ ERROR ]  Cannot read property 'type' of null

[ ERROR ]  rollup died at /Users/matthias/Documents/Projekte/bitflower/Case
           OS/Prototype/v0.2/caseos-ui/node_modules/@stencil/core/dist/compiler/index.js:16780:19
           at Generator.throw (<anonymous>) at rejected
           (/Users/matthias/Documents/Projekte/bitflower/Case
           OS/Prototype/v0.2/caseos-ui/node_modules/@stencil/core/dist/compiler/index.js:16738:65)
           at <anonymous>

[27:13.5]  build failed, watching for changes... 

Expected behavior:
Compiles without errors.

Steps to reproduce:
Check out the repo, npm install, npm run dev
(Check the remarks regarding the check in files from node_modules!)

The repo is on 0.7.17 but the problem persist up to 0.7.24 (latest as of today)

REPO

I have added @jthoms1 and @adamdbradley to this private repo.

Related code:

// insert any relevant code here
@ionitron-bot ionitron-bot bot added the triage label Apr 15, 2018
@adamdbradley
Copy link
Contributor

Looks like it may have something to do with our dependencies: 57db812#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

@bitflower
Copy link
Contributor Author

bitflower commented Apr 16, 2018

2 major ups involved... sounds like a potential!

Can this be covered with 1-2 tests?

EDIT: Like some "example builds" with different npm dependencies n' stuff?

@adamdbradley
Copy link
Contributor

Sure can. Would you be able to help debug this? I'm not sure where in your app it's breaking.

@bitflower
Copy link
Contributor Author

This would mean to debug the Stencil compiler right? Never went this "deep" LOL. But I can try....

@creal73
Copy link

creal73 commented Apr 16, 2018

Hi guys, I will investigate on my side too. I have the same kind of error using d3-force package

@jgw96 jgw96 added Awaiting Reply This PR or Issue needs a reply from the original reporter. and removed triage labels Apr 16, 2018
@bitflower
Copy link
Contributor Author

bitflower commented Apr 16, 2018

Hey @jgw96 The repo provided in the issue is "minimal" in the way that you only need to npm install and you're good to go. Sure, if you want to go ahead after fixing this issue you'll fall into #494 but this shouldn't matter for now....

I've added you to the collaborators.

@jgw96 jgw96 removed the Awaiting Reply This PR or Issue needs a reply from the original reporter. label Apr 18, 2018
@bitflower
Copy link
Contributor Author

Hey guys, I tried to dig into the compiler but I‘m really having trouble setting up console logs, breakpoints and stuff. Anything else I can provide? Is the repo too „complicated“? Do you the smaller one requested by @jgw96?

@jthoms1
Copy link
Member

jthoms1 commented Apr 26, 2018

I have validated that PR #760 resolves this issue. Please update your config to the following. Note that the only change was adding nodeResolve with browser as true.

This is not yet released but should be today.

This is per the documentation provided by rollup-plugin-node-resolve. https://github.com/rollup/rollup-plugin-node-resolve#usage

exports.config = {
  nodeResolve: {
    browser: true
  }
};

exports.devServer = {
  root: 'www',
  watchGlob: '**/**'
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants