New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: button ion-button icon-only is now a slot attribute of child element ion-icon #107

Open

dagobit opened this issue Apr 18, 2019 · 0 comments

Labels

dagobit commented Apr 18, 2019 •

edited

If you used the directive "icon-only" within the button element:

<button ion-button icon-only>
 <ion-icon name="star"></ion-icon>
</button>

it now should be:

<ion-button>
 <ion-icon name="star" slot="icon-only"></ion-icon>
</ion-button>

currently any rule is replacing it, the result of ... --fix is:

<ion-button icon-only>
 <ion-icon name="star"></ion-icon>
</ion-button>

The text was updated successfully, but these errors were encountered:

imhoffd added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment