Update Dependencies & Go #35
Conversation
chore: update dependencies
|
Well, the tests seem to fail, but the exact same query fails on the live version: 
I don't think the current tests are very reproducible as they rely on having Kubo installed and running, as well as an active Internet connection, and specific expectations from the network. |
daemon.go
Outdated
| func providerRecordInDHT(ctx context.Context, d kademlia, c cid.Cid, p peer.ID) bool { | ||
| func providerRecordInDHT(ctx context.Context, d kademlia, c cid.Cid) bool { |
There was a problem hiding this comment.
What's the idea behind the change here? This version seems to answer the question "has anyone advertised the record" which is different from "did node X that is hosting the data advertise it has the data".
Unless this is part of bigger changes towards #24 or #6, seems like we'd rather answer the second question. Otherwise, someone might see:
✔ Successfully connected to multiaddr
✔ Found multiaddr with 2 dht peers
✔ Found the multihash in the dht
✔ Successfully downloaded the CID from the peer
and yet the data would still not be retrievable because a different peer (who is unreachable) had advertised themselves in the DHT but this one had not
There was a problem hiding this comment.
Ah, okay. I will revert this. I would also like to actually incorporate the features from #24. I don't mind tackling that in this PR.
Regarding the tests:
- Locally only one test is failing: checking if the bootstrap peer has the empty directory.
- In the CI there's more tests failing.
I still have to take a better look at it.
TODO: rewrite initial comment with the goals of this PR.
- Update dependencies and Go version (closes Upgrade go-libp2p for quic-v1 multiaddrs to work #34)
- Port features from
pl-diagnose(closes Port features from pl-diagnose #24) - Allow testing using CID only (closes Allow for testing using only a CID #6, likely addressed by above)
- Try getting the UCI going (maybe another PR)
- Improve Dockerfile (based on someguy/rainbow)
|
I'm closing this as it's unlikely that I'll get back to this until EOM. Feel free to reuse any of the commits in the future. |
Closes #34.