Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent API #55

Open
anacrolix opened this issue Dec 18, 2018 · 2 comments
Open

Inconsistent API #55

anacrolix opened this issue Dec 18, 2018 · 2 comments
Projects
ipfs/go-ipfs

Comments

@anacrolix
Copy link

  • SetLogLevel has a special case for *, yet SetAllLoggers exists.
  • SetLogLevel takes level as a string, instead of a "github.com/whyrusleeping/go-logging".Level.
@momack2 momack2 added this to Inbox in ipfs/go-ipfs May 9, 2019
@iand
Copy link
Contributor

iand commented May 19, 2020

I believe both of these inconsistencies are to for backwards compatible support for existing clients of the package

@Kubuxu
Copy link
Member

Kubuxu commented Jun 18, 2020

There is still quite a way until we update everything to v2.
Maybe we should look at doing major cleanup as v3 and update to it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
ipfs/go-ipfs
Inbox
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iand @anacrolix @Kubuxu