Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-blocking logging #76

Open
Stebalien opened this issue Mar 31, 2020 · 1 comment
Open

Non-blocking logging #76

Stebalien opened this issue Mar 31, 2020 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

The default zap file backend logging backend is really dumb and doesn't have any internal buffering. We need to:

  1. Buffer writes.
  2. Drop log messages when the buffer is full instead of blocking.

We should never block execution on logging.
@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 31, 2020
@Stebalien
Copy link
Member Author

Turns out zap support sampling and we've disabled it. We should enable and tune it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stebalien