Disable Brave redirect when Companion global redirect is enabled #1301
Labels
area/brave
Issues related to Brave Browser
kind/bug
A bug in existing code (including security flaws)
P1
High: Likely tackled by core team if no one steps up
This is MVP subset of #1281 requested by the Brave team.
Problem
Currently, Companion logic is clashing with Brave logic when both have redirects enabled.
Proposed fix
The provisional fix is to periodically check if all below are true:
- Companion's global redirect is enabled
- Companion's backend type is Kubo RPC provided by Brave
- Brave settings have redirect enabled (read via
chrome.ipfs.getSettings
)If true, we want to
chrome.ipfs.setGatewayFallbackEnabled(false)
andchrome.ipfs.setAutoRedirectToConfiguredGatewayEnabled(false)
), ensuring only Companion ones are executedThe text was updated successfully, but these errors were encountered: