Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Run E2E tests against version at API port's /webui #3010

Closed
lidel opened this issue Apr 28, 2020 · 4 comments
Closed

Run E2E tests against version at API port's /webui #3010

lidel opened this issue Apr 28, 2020 · 4 comments
Assignees
Labels
kind/wontfix need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Apr 28, 2020

Needs #2984 to land first

Thanks to #2706 we have E2E tests that check if js-ipfs is compatible with ipfs-webui's master branch, but we don't run those tests against the webui version aliased at /webui on API port.

Over time, support for older version at /webui may break, while the master of webui continues to work with js-ipfs master, which means we miss some regressions.

A fix here would be to run ipfs-webui E2E test suite against version at /webui at well:

  • extract CID from packages/ipfs/src/http/api/routes/webui.js
  • prefetch it and cache so CI is not slowed down
  • make it a separate task in CI with distinct name (eg. ipfs-webui(/webui))
  • no need to run it twice
@lidel lidel added need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) need/triage Needs initial labeling and prioritization labels Apr 28, 2020
@achingbrain
Copy link
Member

no need to run it twice

Would we not want to run it on FF & Chrome?

@lidel
Copy link
Member Author

lidel commented Apr 28, 2020

Right now E2E run only against Chromium. Running against Firefox should be possible now that puppeteer added support ipfs/ipfs-webui#1164 (comment), but its not implemented yet.

What I meant by "running twice" was that E2E is running once against "release" version and then the second time against "PR" version to detect regressions. When we add E2E against /webui that needs to run only "once".

@SgtPooki SgtPooki self-assigned this May 17, 2023
@SgtPooki
Copy link
Member

@BigLep I believe this one is irrelevant for helia because we're detaching js-ipfs from webui

@BigLep
Copy link
Contributor

BigLep commented May 17, 2023

Agreed. We can close this given webui is detached from js-ipfs and Helia.

@BigLep BigLep closed this as completed May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/wontfix need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants