Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publicsuffix check #133

Open
lidel opened this issue Feb 3, 2021 · 0 comments
Open

Add publicsuffix check #133

lidel opened this issue Feb 3, 2021 · 0 comments
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Feb 3, 2021

If gateway is a subdomain one, we should also test if it is on the Public Suffix List used by browsers.

Why? Without PSL the owner of the suffix can access cookies of subdomains,
so lack of PSL requires putting more trust into gateway operator.

Ref.
@lidel lidel added the need/triage Needs initial labeling and prioritization label Feb 3, 2021
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked labels Feb 8, 2021
@lidel lidel removed the need/triage Needs initial labeling and prioritization label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Planned / Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @jessicaschilling