Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with dynamic CID #157

Open
lidel opened this issue Jun 21, 2021 · 2 comments
Open

Test with dynamic CID #157

lidel opened this issue Jun 21, 2021 · 2 comments
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now

Comments

@lidel
Copy link
Member

lidel commented Jun 21, 2021

@schomatis raised a good point in #156 (comment)

My only request would be that CID we're using to test subdomain redirection not be static so a malicious/lazy gateway couldn't just bypass it with a basic redirect that doesn't even understand the protocol.

Good idea, but implementation needs more analysis. The main challenge here is content routing speed – if we generate random text for each page load, it will take some time for gateways to find it and implies the page needs to run js-ipfs with some relay/preload setup.

@lidel lidel added the need/triage Needs initial labeling and prioritization label Jun 21, 2021
@lidel lidel added effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now and removed need/triage Needs initial labeling and prioritization labels Jul 23, 2021
@jonaharagon
Copy link
Contributor

jonaharagon commented Jul 26, 2021

You could set up a CI (GitHub Actions?) which generates random text for each pushed commit instead (or on a set interval), pins that text somewhere, and deploys a version of the website which checks for that hash. It wouldn't be randomized per page load, but often enough that you couldn't trivially bypass the check.

If you did this on the browser side not only would you need js-ipfs, but the measurement time would be measuring the time it takes for a gateway to fetch content from the js-ipfs client, rather than the response time of content they already have cached. I can see how that'd be useful to someone, but it's still probably less useful for most people looking for public gateways.

With this setup you could also do other neat things like automatically pin/publish the site on IPFS to tackle some #93 problems.

@SgtPooki SgtPooki added the exp/intermediate Prior experience is likely helpful label Jul 13, 2022
@SgtPooki
Copy link
Member

I think this would make a great second test. I don't think we should replace our existing static CID tests, but we should add an additional test using the methods proposed by @jonaharagon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

3 participants