Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle special resolvers in CI #364

Open
1 task
SgtPooki opened this issue Jan 10, 2023 · 2 comments
Open
1 task

feat: Handle special resolvers in CI #364

SgtPooki opened this issue Jan 10, 2023 · 2 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jan 10, 2023

We need to update CI to check for stale gateways (there is an issue for this, but I don't have the link right now). We need to ensure that special gateways have the appropriate logic so that they're not considered obsolete when the CI workflow runs.

subtasks

  • create special-gateways.json for gateways that require a special resolver logic

related

@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Jan 10, 2023
@lidel
Copy link
Member

lidel commented Jan 12, 2023

Perhaps we should move these special gateways away from gateways.json into a special-gateways.json and include additional metadata about the type (Tor, Handshake, etc) with link to software that is required for use?

This way testing on CI will be easier: we will be able to test Handshake and Tor ones in separate jobs with different resolvers/setups etc.

@SgtPooki
Copy link
Member Author

@lidel i like that idea. Should be easy to do while also helping call them out for those interested, instead of having to infer it from buried logic.

@SgtPooki SgtPooki added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up and removed need/triage Needs initial labeling and prioritization labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

2 participants