forked from crewjam/saml
/
service_provider_go116_test.go
136 lines (118 loc) · 6.52 KB
/
service_provider_go116_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
//go:build !go1.17
// +build !go1.17
package saml
import (
"encoding/base64"
"encoding/xml"
"net/http"
"net/url"
"strings"
"testing"
"time"
dsig "github.com/russellhaering/goxmldsig"
"gotest.tools/assert"
is "gotest.tools/assert/cmp"
"gotest.tools/golden"
)
func TestSPRejectsMalformedResponse(t *testing.T) {
test := NewServiceProviderTest(t)
// An actual response from google
TimeNow = func() time.Time {
rv, _ := time.Parse("Mon Jan 2 15:04:05 UTC 2006", "Tue Jan 5 16:55:39 UTC 2016")
return rv
}
Clock = dsig.NewFakeClockAt(TimeNow())
SamlResponse := golden.Get(t, "TestSPRejectsMalformedResponse_response")
test.IDPMetadata = golden.Get(t, "TestSPRejectsMalformedResponse_IDPMetadata")
s := ServiceProvider{
Key: test.Key,
Certificate: test.Certificate,
MetadataURL: mustParseURL("https://29ee6d2e.ngrok.io/saml/metadata"),
AcsURL: mustParseURL("https://29ee6d2e.ngrok.io/saml/acs"),
IDPMetadata: &EntityDescriptor{},
}
err := xml.Unmarshal(test.IDPMetadata, &s.IDPMetadata)
assert.Check(t, err)
// this is a valid response
{
req := http.Request{PostForm: url.Values{}}
req.PostForm.Set("SAMLResponse", string(SamlResponse))
assertion, err := s.ParseResponse(&req, []string{"id-fd419a5ab0472645427f8e07d87a3a5dd0b2e9a6"})
assert.Check(t, err)
assert.Check(t, is.Equal("ross@octolabs.io", assertion.Subject.NameID.Value))
}
// this is a valid response but with a comment injected
{
x, _ := base64.StdEncoding.DecodeString(string(SamlResponse))
y := strings.Replace(string(x), "<saml2p:Response", "<saml2p:Response ::foo=\"bar\"", 1)
SamlResponse = []byte(base64.StdEncoding.EncodeToString([]byte(y)))
req := http.Request{PostForm: url.Values{}}
req.PostForm.Set("SAMLResponse", string(SamlResponse))
assertion, err := s.ParseResponse(&req, []string{"id-fd419a5ab0472645427f8e07d87a3a5dd0b2e9a6"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"invalid xml: validator: in token starting at 1:55: roundtrip error: expected {{saml2p Response} [{{ :foo} bar} {{xmlns saml2p} urn:oasis:names:tc:SAML:2.0:protocol} {{ Destination} https://29ee6d2e.ngrok.io/saml/acs} {{ ID} _fc141db284eb3098605351bde4d9be59} {{ InResponseTo} id-fd419a5ab0472645427f8e07d87a3a5dd0b2e9a6} {{ IssueInstant} 2016-01-05T16:55:39.348Z} {{ Version} 2.0}]}, observed {{ Response} [{{ xmlns} saml2p} {{ foo} bar} {{xmlns saml2p} urn:oasis:names:tc:SAML:2.0:protocol} {{ Destination} https://29ee6d2e.ngrok.io/saml/acs} {{ ID} _fc141db284eb3098605351bde4d9be59} {{ InResponseTo} id-fd419a5ab0472645427f8e07d87a3a5dd0b2e9a6} {{ IssueInstant} 2016-01-05T16:55:39.348Z} {{ Version} 2.0} {{ Version} 2.0}]}"))
assert.Check(t, is.Nil(assertion))
}
}
func TestSPInvalidResponses(t *testing.T) {
test := NewServiceProviderTest(t)
s := ServiceProvider{
Key: test.Key,
Certificate: test.Certificate,
MetadataURL: mustParseURL("https://15661444.ngrok.io/saml2/metadata"),
AcsURL: mustParseURL("https://15661444.ngrok.io/saml2/acs"),
IDPMetadata: &EntityDescriptor{},
}
err := xml.Unmarshal(test.IDPMetadata, &s.IDPMetadata)
assert.Check(t, err)
req := http.Request{PostForm: url.Values{}}
req.PostForm.Set("SAMLResponse", "???")
_, err = s.ParseResponse(&req, []string{"id-9e61753d64e928af5a7a341a97f420c9"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"cannot parse base64: illegal base64 data at input byte 0"))
req.PostForm.Set("SAMLResponse", base64.StdEncoding.EncodeToString([]byte("<hello>World!</hello>")))
_, err = s.ParseResponse(&req, []string{"id-9e61753d64e928af5a7a341a97f420c9"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"cannot unmarshal response: expected element type <Response> but have <hello>"))
req.PostForm.Set("SAMLResponse", base64.StdEncoding.EncodeToString(test.SamlResponse))
_, err = s.ParseResponse(&req, []string{"wrongRequestID"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"`InResponseTo` does not match any of the possible request IDs (expected [wrongRequestID])"))
TimeNow = func() time.Time {
rv, _ := time.Parse("Mon Jan 2 15:04:05 MST 2006", "Mon Nov 30 20:57:09 UTC 2016")
return rv
}
Clock = dsig.NewFakeClockAt(TimeNow())
req.PostForm.Set("SAMLResponse", base64.StdEncoding.EncodeToString(test.SamlResponse))
_, err = s.ParseResponse(&req, []string{"id-9e61753d64e928af5a7a341a97f420c9"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"response IssueInstant expired at 2015-12-01 01:57:51.375 +0000 UTC"))
TimeNow = func() time.Time {
rv, _ := time.Parse("Mon Jan 2 15:04:05 MST 2006", "Mon Dec 1 01:57:09 UTC 2015")
return rv
}
Clock = dsig.NewFakeClockAt(TimeNow())
s.IDPMetadata.EntityID = "http://snakeoil.com"
req.PostForm.Set("SAMLResponse", base64.StdEncoding.EncodeToString(test.SamlResponse))
_, err = s.ParseResponse(&req, []string{"id-9e61753d64e928af5a7a341a97f420c9"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"response Issuer does not match the IDP metadata (expected \"http://snakeoil.com\")"))
s.IDPMetadata.EntityID = "https://idp.testshib.org/idp/shibboleth"
oldSpStatusSuccess := StatusSuccess
StatusSuccess = "not:the:success:value"
req.PostForm.Set("SAMLResponse", base64.StdEncoding.EncodeToString(test.SamlResponse))
_, err = s.ParseResponse(&req, []string{"id-9e61753d64e928af5a7a341a97f420c9"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"urn:oasis:names:tc:SAML:2.0:status:Success"))
StatusSuccess = oldSpStatusSuccess
s.IDPMetadata.IDPSSODescriptors[0].KeyDescriptors[0].KeyInfo.X509Data.X509Certificates[0].Data = "invalid"
req.PostForm.Set("SAMLResponse", base64.StdEncoding.EncodeToString(test.SamlResponse))
_, err = s.ParseResponse(&req, []string{"id-9e61753d64e928af5a7a341a97f420c9"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"cannot validate signature on Response: cannot parse certificate: illegal base64 data at input byte 4"))
s.IDPMetadata.IDPSSODescriptors[0].KeyDescriptors[0].KeyInfo.X509Data.X509Certificates[0].Data = "aW52YWxpZA=="
req.PostForm.Set("SAMLResponse", base64.StdEncoding.EncodeToString(test.SamlResponse))
_, err = s.ParseResponse(&req, []string{"id-9e61753d64e928af5a7a341a97f420c9"})
assert.Check(t, is.Error(err.(*InvalidResponseError).PrivateErr,
"cannot validate signature on Response: asn1: structure error: tags don't match (16 vs {class:1 tag:9 length:110 isCompound:true}) {optional:false explicit:false application:false private:false defaultValue:<nil> tag:<nil> stringType:0 timeType:0 set:false omitEmpty:false} certificate @2"))
}