Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] TODO we should consolidate these forward refs with ... #129

Open
github-actions bot opened this issue Nov 5, 2023 · 0 comments
Open

[AutoPR] TODO we should consolidate these forward refs with ... #129

github-actions bot opened this issue Nov 5, 2023 · 0 comments
Labels

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023

TODO we should consolidate these forward refs with their definitions in config.py workflow_service uses this, which is why it's here instead

if value in cls.reserved_keywords:
raise ValueError(f"{value} is a reserved keyword")
return str.__new__(cls, value)
# TODO we should consolidate these forward refs with their definitions in `config.py`
# workflow_service uses this, which is why it's here instead
ExecutableForwardRef = Union[
ExecutableId,
# ControlWords,
ForwardRef("ActionConfigs"), # pyright: ignore[reportGeneralTypeIssues]
ForwardRef("WorkflowInvocation"), # pyright: ignore[reportGeneralTypeIssues]

When resolving this TODO, you can start by identifying all the forward references in your code and their corresponding definitions in config.py. Then, consolidate these forward references with their definitions in config.py to eliminate any duplication. Finally, make sure to update any references to the consolidated definitions in your code.

@github-actions github-actions bot added the medium label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants