From f318a5ec6932317de40683978137eb88e9b70c1f Mon Sep 17 00:00:00 2001 From: isaacs Date: Wed, 3 Jul 2019 11:38:32 -0700 Subject: [PATCH] don't try to chown /bin/sh in test on Linux --- test/symlink-sync.js | 3 ++- test/symlink.js | 11 +++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/test/symlink-sync.js b/test/symlink-sync.js index 2faa3d4..0ebbc6d 100644 --- a/test/symlink-sync.js +++ b/test/symlink-sync.js @@ -27,7 +27,8 @@ exec("id", function (code, output) { rimraf("dir", function (er) { if (er) throw er fs.mkdirSync("dir") - fs.symlinkSync("/bin/sh", "dir/sh-link") + fs.writeFileSync("dir/sh") + fs.symlinkSync("./sh", "dir/sh-link") runTest() }) }) diff --git a/test/symlink.js b/test/symlink.js index 9811558..a67e4e0 100644 --- a/test/symlink.js +++ b/test/symlink.js @@ -2,6 +2,9 @@ if (!process.getuid || !process.getgid) { throw new Error("Tests require getuid/getgid support") } +var skip = process.platform === 'darwin' ? false + : 'linux and windows do not treat links as separate fs objects' + var curUid = +process.getuid() , curGid = +process.getgid() , chownr = require("../") @@ -28,7 +31,8 @@ exec("id", function (code, output) { rimraf("dir", function (er) { if (er) throw er fs.mkdirSync("dir") - fs.symlinkSync("/bin/sh", "dir/sh-link") + fs.writeFileSync("dir/sh") + fs.symlinkSync("./sh", "dir/sh-link") runTest() }) }) @@ -48,8 +52,8 @@ function runTest () { t.ifError(er) return t.end() } - t.notEqual(st.uid, curUid, "uid not should be " + curUid) - t.notEqual(st.gid, groups[0], "gid not should be "+groups[0]) + t.notEqual(st.uid, curUid, "uid", {skip}) + t.notEqual(st.gid, groups[0], "gid", {skip}) t.end() }) }) @@ -62,4 +66,3 @@ function runTest () { }) }) } -