Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EISDIR from lchown in node <10.6 #21

Merged
merged 3 commits into from Jul 3, 2019
Merged

Handle EISDIR from lchown in node <10.6 #21

merged 3 commits into from Jul 3, 2019

Conversation

isaacs
Copy link
Owner

@isaacs isaacs commented Jul 3, 2019

Fix #20

@coveralls
Copy link

Coverage Status

Coverage increased (+9.9%) to 87.5% when pulling 233e197 on handle-eisdir into 7a5c3d5 on master.

@coveralls
Copy link

coveralls commented Jul 3, 2019

Coverage Status

Coverage increased (+8.2%) to 85.714% when pulling d3e5d3f on handle-eisdir into 7a5c3d5 on master.

@isaacs isaacs changed the title Handle EISDIR from lchown in node v8 Handle EISDIR from lchown in node <10.6 Jul 3, 2019
@isaacs isaacs force-pushed the handle-eisdir branch 2 times, most recently from f318a5e to ee47a66 Compare July 3, 2019 21:25
These tests depend on being able to lchown a symbolic link to /bin/sh,
and rely on the assumption that /bin/sh is not owned by the current
user.

The first assumption will typically fail on Linux whenever the second
assumption is true!

Fixing the first, by linking to a local file instead, means that the
second is violated.

There is no way to save these tests, so they are being removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EISDIR error when invoked from cacache under sudo to fix ownership on MacOS
2 participants