-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: purgeStale sometimes gets stuck in an infinite loop #209
Comments
I can confirm this bug. |
Ahh, yes, because delete changes the linked list order. Good catch and root cause. Will fix shortly. |
fixed on 7.4.3 by accident, on 7.4.4 on purpose 😬 |
backported to other 7.x versions |
im not able to get my head around why infinite loop leads to infinite getpid syscalls as shown nodejs/node#42277 . any ideas? |
@palashkulsh Idk, you'd have to ask them. LRUCache doesn't do any getpid() calls. |
We found out that since we updated to v7 sometimes lru-cache would get stuck inside the purgeStale function
(lame) test
you will see it gets stuck in purge start
The solution seems to be to make the purgeStale function "cache" the items to delete and delete it after the rindexes iteration, or else it may get stuck in an infinite iteration
The text was updated successfully, but these errors were encountered: