Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: isaacs/node-mkdirp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.4
Choose a base ref
...
head repository: isaacs/node-mkdirp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.5
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Apr 3, 2020

  1. Remove unnecessary umask calls

    Legacy fix for #22
    Re nodejs/node#32321
    isaacs committed Apr 3, 2020

    Verified

    This commit was signed with the committer’s verified signature.
    Okeanos Nikolas Grottendieck
    Copy the full SHA
    bea6382 View commit details
  2. 0.5.5

    isaacs committed Apr 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    049cf18 View commit details
Showing with 6 additions and 34 deletions.
  1. +2 −2 index.js
  2. +1 −1 package-lock.json
  3. +1 −1 package.json
  4. +2 −2 readme.markdown
  5. +0 −28 test/umask.js
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ function mkdirP (p, opts, f, made) {
var xfs = opts.fs || fs;

if (mode === undefined) {
mode = _0777 & (~process.umask());
mode = _0777
}
if (!made) made = null;

@@ -62,7 +62,7 @@ mkdirP.sync = function sync (p, opts, made) {
var xfs = opts.fs || fs;

if (mode === undefined) {
mode = _0777 & (~process.umask());
mode = _0777
}
if (!made) made = null;

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "mkdirp",
"description": "Recursively mkdir, like `mkdir -p`",
"version": "0.5.4",
"version": "0.5.5",
"publishConfig": {
"tag": "legacy"
},
4 changes: 2 additions & 2 deletions readme.markdown
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ Create a new directory and any necessary subdirectories at `dir` with octal
permission string `opts.mode`. If `opts` is a non-object, it will be treated as
the `opts.mode`.

If `opts.mode` isn't specified, it defaults to `0777 & (~process.umask())`.
If `opts.mode` isn't specified, it defaults to `0777`.

`cb(err, made)` fires with the error or the first directory `made`
that had to be created, if any.
@@ -52,7 +52,7 @@ Synchronously create a new directory and any necessary subdirectories at `dir`
with octal permission string `opts.mode`. If `opts` is a non-object, it will be
treated as the `opts.mode`.

If `opts.mode` isn't specified, it defaults to `0777 & (~process.umask())`.
If `opts.mode` isn't specified, it defaults to `0777`.

Returns the first directory that had to be created, if any.

28 changes: 0 additions & 28 deletions test/umask.js

This file was deleted.