Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(sqf) support the latest version 2.02 of Arma 3. #3084

Merged
merged 6 commits into from Mar 28, 2021
Merged

enh(sqf) support the latest version 2.02 of Arma 3. #3084

merged 6 commits into from Mar 28, 2021

Conversation

R3voA3
Copy link
Contributor

@R3voA3 R3voA3 commented Mar 27, 2021 •
edited

Changes

  • Updated sqf.js language file to support the latest commands introduced with version 2.02 of Arma 3.
  • Updated CHANGES.md

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

joshgoebel
joshgoebel reviewed Mar 27, 2021
View reviewed changes
src/languages/sqf.js Outdated Show resolved Hide resolved
@joshgoebel joshgoebel changed the title Update sqf.js (sql) support the latest commands introduced with version 2.02 of Arma 3. Mar 27, 2021
@joshgoebel joshgoebel changed the title (sql) support the latest commands introduced with version 2.02 of Arma 3. enh(sqf) support the latest commands introduced with version 2.02 of Arma 3. Mar 27, 2021
@joshgoebel joshgoebel changed the title enh(sqf) support the latest commands introduced with version 2.02 of Arma 3. enh(sqf) support the latest version 2.02 of Arma 3. Mar 27, 2021
@joshgoebel
Copy link
Member

Also, what is your involvement with SQF?

@dedmen
Copy link
Contributor

dedmen commented Mar 27, 2021

Also, what is your involvement with SQF?

R3vo is community member. I'm Arma developer, I will review later today but I don't expect any problems here

dedmen
dedmen reviewed Mar 27, 2021
View reviewed changes
src/languages/sqf.js Outdated Show resolved Hide resolved
dedmen
dedmen reviewed Mar 27, 2021
View reviewed changes
src/languages/sqf.js Outdated Show resolved Hide resolved
@R3voA3
Update sqf.js
40d438d 
- Converted keywords to an array (Thanks Lou)
@R3voA3 R3voA3 marked this pull request as ready for review March 28, 2021 11:10
@joshgoebel
Copy link
Member

Please follow PR template and update CHANGES.md also.

@R3voA3
Update CHANGES.md
37dc24e 
- Added changes of #3084
@R3voA3
Copy link
Contributor Author

R3voA3 commented Mar 28, 2021

Please follow PR template and update CHANGES.md also.

Done, although I have no clue about markup tests so I left it unchecked.

@dedmen
Copy link
Contributor

dedmen commented Mar 28, 2021

Looks good for me.
But might aswell do 2.04 directly https://community.bistudio.com/wiki/Category:Arma_3_Development_Branch:_New_Scripting_Commands
2.04 will be out before Discord updated their highlightjs :D

@R3voA3
Copy link
Contributor Author

R3voA3 commented Mar 28, 2021

Looks good for me.
But might aswell do 2.04 directly https://community.bistudio.com/wiki/Category:Arma_3_Development_Branch:_New_Scripting_Commands
2.04 will be out before Discord updated their highlightjs :D

True, should we also update the list with new preprocessor instructions?

joshgoebel
joshgoebel reviewed Mar 28, 2021
View reviewed changes
CHANGES.md Show resolved Hide resolved
R3voA3 and others added 2 commits March 28, 2021 16:18
@R3voA3
Update CHANGES.md
7974e24 
- properly linked to my profile
@joshgoebel
Update CHANGES.md
03851d5
@joshgoebel joshgoebel merged commit d4e1593 into highlightjs:main Mar 28, 2021
@joshgoebel
Copy link
Member

@R3voA3 Thanks so much!

NullVoxPopuli pushed a commit to NullVoxPopuli/highlight.js that referenced this pull request Apr 3, 2021
@R3voA3 @NullVoxPopuli
enh(sqf) support the latest version 2.02 of Arma 3. (highlightjs#3084)
9c881b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

@dedmen dedmen dedmen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@R3voA3 @joshgoebel @dedmen