enh(sqf) improve function name highlighting (slightly broader) #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should clean up highlights for functions named "ace_medical_fnc_addStatus" or etc
|
I have not updated the changelog yet as I did not see a Version next or whatever to place it under and I don't want to cause a merge conflict. Where should I place it? |
|
Thanks! The topmost section is the v11 stuff it would go there, at the bottom of that section with all the other grammar improvements. |
joshgoebel
reviewed
May 8, 2021
joshgoebel
reviewed
May 10, 2021
joshgoebel
approved these changes
May 10, 2021
joshgoebel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tweaked the function matching regex for the sqf language so that it can match functions with the
myTag_component_fnc_initVehiclenaming convention which is common with popular mods for arma, CBA, ACE, etc.Changes
Changed regex for sqf functions to
\w+_fnc_\w+which matches the whole word now instead of just one section.Checklist
CHANGES.md