Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types) Fix some type definition issues #3274

Merged
merged 6 commits into from Jul 23, 2021
Merged

fix(types) Fix some type definition issues #3274

merged 6 commits into from Jul 23, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Jul 14, 2021 •
edited

Should resolve #3272 and #3273.

Changes

  • fix(types) begin, match, end all now take arrays
  • fix(types) _emit now a scope attribute, not mode attribute
  • fix(types) do not forget about endScope
  • remove dead code
  • fix(types) make hljs not optional

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel changed the title fixup types fix(types) Fix some type definition issues Jul 14, 2021
@joshgoebel
Copy link
Member Author

@jsharkey13

jsharkey13
jsharkey13 approved these changes Jul 15, 2021
View reviewed changes
Copy link

@jsharkey13 jsharkey13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't easily build and test this, but it definitely contains the changes I expected to fix the two issues. Thanks!

@joshgoebel joshgoebel merged commit ba8735f into highlightjs:main Jul 23, 2021
@joshgoebel
Copy link
Member Author

@jsharkey13 Thanks!

@joshgoebel joshgoebel mentioned this pull request Jul 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsharkey13 jsharkey13 jsharkey13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type errors declaring a new language definition in TypeScript
2 participants
@joshgoebel @jsharkey13