Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests say Success: null ms - a problem? #110

Closed
TomasHubelbauer opened this issue Mar 21, 2018 · 4 comments
Closed

Tests say Success: null ms - a problem? #110

TomasHubelbauer opened this issue Mar 21, 2018 · 4 comments

Comments

@TomasHubelbauer
Copy link
Member

TomasHubelbauer commented Mar 21, 2018

Hey, maybe this is just my confusion, but most (all?) tests running in SauceLabs seem to be returning null for the runtime value in ms. I meant to take a look at a random session from my latest PR, but the video doesn't load for me to be able to check on whether the execution goes through okay. Are there any more tools that could be used to verify nothing is amiss?

@billiegoose
Copy link
Member

I noticed this happening even locally today. I think it may be a bug in the reporter.

@billiegoose
Copy link
Member

Being resolved over yonder: karma-runner/karma-jasmine#197

@billiegoose
Copy link
Member

I'm closing this for now, simply because when the upstream module merges the fix and that fix makes it into a release, @greenkeeperio-bot will create a PR to update our package.json, and then we'll be running the latest version of karma-jasmine and the issue will be fixed. That's the fastest we could possibly fix it anyway, short of forking karma-jasmine and patching it ourselves, which seems very silly.

@billiegoose
Copy link
Member

And it's been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants