Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell CI: Remove a single github workflow , move into azure-pipelines.yml #1877

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented Mar 7, 2024

currently running codespell requires approval since I guess there are some secrets set for the repo.

I made it last in the azure-pipelines.yml so there is no interference of any kind on prior "non-pythonic" steps

Related

Closes #1875

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Description of fix]"

…to secrets) - move into azure-pipelines.yml

I made it last in the azure-pipelines.yml so there is no interference of any kind on prior "non-pythonic" steps
@seanpoulter
Copy link
Contributor

Is there another solution we should consider? The goal of #1496 is to only use GitHub Actions.

@yarikoptic
Copy link
Contributor Author

Is there another solution we should consider? The goal of #1496 is to only use GitHub Actions.

but it is not the case ATM and you are using azure -- so I decided to harmonize into it.

I have not found relevant information -- seems like you have some github secrets for actions and that is why an action from a personal fork seems to require approval even if not using any of the secrets. @jwodder -- do you know more on this? codespell workflow here requires approval although not using any secrets -- any way to overcome without some complicated additional bot/action to auto-approve it?

@yarikoptic yarikoptic marked this pull request as ready for review March 8, 2024 14:39
@jwodder
Copy link

jwodder commented Mar 8, 2024

@yarikoptic This is just how GitHub works:

[W]orkflows on pull requests to public repositories from some outside contributors will not run automatically, and might need to be approved first. By default, all first-time contributors require approval to run workflows.

@jcubic
Copy link
Contributor

jcubic commented Mar 8, 2024

Ah, ok. Didn't know about it. So we can ignore this. Sorry for the trouble. I guess we will need to accept all actions when we migrate to GH workflows. I thought it was some kind of mistake that could be fixed.

@seanpoulter
Copy link
Contributor

We could pivot a bit and document the behaviour so contributors know what to expect. What do you think?

@jcubic
Copy link
Contributor

jcubic commented Mar 9, 2024

Good idea, let's do this after migration to GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codespell workflow needs approval
4 participants