Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support turning off node_modules default exclude via flag #172

Merged
merged 1 commit into from May 16, 2019

Conversation

hershmire
Copy link
Contributor

This PR is part of resolving issue #898. The idea is to be able to turn off the default exclusion of **/node_modules/** for users that need/want to support local node_modules. As mentioned in that issue, the negateExclude (i.e. !**/node_modules/**) doesn't work for cases when you still want your exclusion list to still exclude matches within your local node_modules directory.

Related PRs for solving the above issue:

NOTE: this test-exclude PR (istanbuljs/istanbuljs#213) will need to get merged and published before this is effective.

@coreyfarrell
Copy link
Member

@hershmire when you have a chance could you fix the lint errors so we can see if this passes testing?

@bcoe
Copy link
Member

bcoe commented May 6, 2019

bump, @hershmire would love to see this over the finish line.

@bcoe bcoe added the blocked label May 6, 2019
@coreyfarrell coreyfarrell merged commit a314f06 into istanbuljs:master May 16, 2019
coreyfarrell added a commit that referenced this pull request May 16, 2019
PR #207 broke tests from #172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants