fix: nyc processing files not covered by include when all is enabled. (#914)

Fixes #913.
Fixes #782.

Author: AGrzes

index.js

@@ -178,14 +178,14 @@ NYC.prototype.addAllFiles = function () {
   this.fakeRequire = true
   this.walkAllFiles(this.cwd, function (filename) {
     filename = path.resolve(_this.cwd, filename)
-    _this.addFile(filename)
-    var coverage = coverageFinder()
-    var lastCoverage = _this.instrumenter().lastFileCoverage()
-    if (lastCoverage) {
-      filename = lastCoverage.path
-    }
-    if (lastCoverage && _this.exclude.shouldInstrument(filename)) {
-      coverage[filename] = lastCoverage
+    if (_this.exclude.shouldInstrument(filename)) {
+      _this.addFile(filename)
+      var coverage = coverageFinder()
+      var lastCoverage = _this.instrumenter().lastFileCoverage()
+      if (lastCoverage) {
+        filename = lastCoverage.path
+        coverage[filename] = lastCoverage
+      }
     }
   })
   this.fakeRequire = false

test/fixtures/transpile-hook.js

@@ -9,3 +9,7 @@ require.extensions['.whatever'] = function (module, filename) {
   var content = fs.readFileSync(filename, 'utf8');
   module._compile(content.replace('--> pork chop sandwiches <--', ''), filename);
 }
+
+require.extensions['.do-not-transpile'] = function (module, filename) {
+  throw new Error(`Should not transpile ${filename}`)
+}

test/src/nyc-tap.js

@@ -440,6 +440,26 @@ describe('nyc', function () {
     return done()
   })
 
+  it('Do not transpiles  files when not included', function (done) {
+    var notNeedTranspilePath = path.join(fixtures, './do-not-need-transpile.do-not-transpile')
+    fs.writeFileSync(
+      notNeedTranspilePath,
+      '--> pork chop sandwiches <--\nvar a = 99',
+      'utf-8'
+    )
+
+    var nyc = (new NYC(configUtil.buildYargs(fixtures).parse([
+      '--require=./test/fixtures/transpile-hook',
+      '--extension=.do-not-transpile',
+      '--include=needs-transpile.do-not-transpile'
+    ])))
+
+    nyc.reset()
+    nyc.addAllFiles()
+    fs.unlinkSync(notNeedTranspilePath)
+    return done()
+  })
+
   describe('cache', function () {
     it('handles collisions', function (done) {
       var nyc = new NYC(configUtil.buildYargs(fixtures).parse())